Skip to content

Commit 5555841

Browse files
committed
refactoring: remove redundant code and rename filter method
1 parent a3cbe56 commit 5555841

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

src/index.ts

+4-8
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ export default class Plugin {
6060

6161
constructor(private readonly config: Config = {}) {}
6262

63-
private filter(fileName: string): boolean {
63+
private isCurrentFileNeedsToBeInlined(fileName: string): boolean {
6464
if (typeof this.config.filter === 'function') {
6565
return this.config.filter(fileName)
6666
} else {
@@ -74,17 +74,13 @@ export default class Plugin {
7474
const { leaveCSSFile } = this.config
7575

7676
Object.keys(assets).forEach((fileName) => {
77-
if (isCSS(fileName)) {
78-
const isCurrentFileNeedsToBeInlined = this.filter(fileName)
79-
if (isCurrentFileNeedsToBeInlined) {
77+
if (this.isCurrentFileNeedsToBeInlined(fileName)) {
78+
if (isCSS(fileName)) {
8079
this.css[fileName] = assets[fileName].source()
8180
if (!leaveCSSFile) {
8281
delete assets[fileName]
8382
}
84-
}
85-
} else if (isHTML(fileName)) {
86-
const isCurrentFileNeedsToBeInlined = this.filter(fileName)
87-
if (isCurrentFileNeedsToBeInlined) {
83+
} else if (isHTML(fileName)) {
8884
this.html[fileName] = assets[fileName].source()
8985
}
9086
}

0 commit comments

Comments
 (0)