From 4e409926198147f24a49c293923d2a2a047c3774 Mon Sep 17 00:00:00 2001 From: Rhys Evans Date: Tue, 28 Jun 2016 17:44:02 +0100 Subject: [PATCH 1/6] Advise against fastclick use --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index de3f2a06..4e659ae3 100644 --- a/README.md +++ b/README.md @@ -4,6 +4,8 @@ FastClick is a simple, easy-to-use library for eliminating the 300ms delay betwe FastClick is developed by [FT Labs](http://labs.ft.com/), part of the Financial Times. +*Note: As of late 2015 most mobile browsers - notably Chrome and Safari - no longer have a 300ms touch delay, so fastclick offers no benefit on newer browsers, and risks introducing [bugs](https://github.com/ftlabs/fastclick/issues) into your application. Consider carefully whether you really need to use it.* + [Explication en français](http://maxime.sh/2013/02/supprimer-le-lag-des-clics-sur-mobile-avec-fastclick/). [日本語で説明](https://developer.mozilla.org/ja/docs/Mozilla/Firefox_OS/Apps/Tips_and_techniques#Make_events_immediate)。 From 7972ec0e4bce4e304a32be34608b915840d6b4b4 Mon Sep 17 00:00:00 2001 From: Breno Calazans Date: Mon, 1 Aug 2016 19:27:37 -0300 Subject: [PATCH 2/6] Fix inputs with type email Fix #485 --- lib/fastclick.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/fastclick.js b/lib/fastclick.js index 3af4f9d6..86bf83e0 100644 --- a/lib/fastclick.js +++ b/lib/fastclick.js @@ -326,7 +326,7 @@ var length; // Issue #160: on iOS 7, some input elements (e.g. date datetime month) throw a vague TypeError on setSelectionRange. These elements don't have an integer value for the selectionStart and selectionEnd properties, but unfortunately that can't be used for detection because accessing the properties also throws a TypeError. Just check the type instead. Filed as Apple bug #15122724. - if (deviceIsIOS && targetElement.setSelectionRange && targetElement.type.indexOf('date') !== 0 && targetElement.type !== 'time' && targetElement.type !== 'month') { + if (deviceIsIOS && targetElement.setSelectionRange && targetElement.type.indexOf('date') !== 0 && targetElement.type !== 'time' && targetElement.type !== 'month' && targetElement.type !== 'email') { length = targetElement.value.length; targetElement.setSelectionRange(length, length); } else { From 0a67ec56a3fe4e78b48d4164ad5f04e82e73f9a2 Mon Sep 17 00:00:00 2001 From: Ed Date: Tue, 30 Aug 2016 10:38:26 +1200 Subject: [PATCH 3/6] add license to bower.json --- bower.json | 1 + 1 file changed, 1 insertion(+) diff --git a/bower.json b/bower.json index 18e1abd4..3cd398ed 100644 --- a/bower.json +++ b/bower.json @@ -1,5 +1,6 @@ { "name": "fastclick", + "license": "MIT", "main": "lib/fastclick.js", "ignore": [ "**/.*", From ba516d570ac880a6c4f2eff578cc6d83a774a045 Mon Sep 17 00:00:00 2001 From: Jorrit Schippers Date: Fri, 3 Mar 2017 10:00:17 +0100 Subject: [PATCH 4/6] Exclude .npmignore and bower.json from npm package --- .npmignore | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.npmignore b/.npmignore index b3ff1517..2411778c 100644 --- a/.npmignore +++ b/.npmignore @@ -1,5 +1,7 @@ .gitignore -Makefile +.npmignore +bower.json component.json -tests examples +Makefile +tests From a4c0ab95326ffa8de0af00769b2f5b7571f380b1 Mon Sep 17 00:00:00 2001 From: Lily2point0 Date: Thu, 14 Feb 2019 15:27:06 +0000 Subject: [PATCH 5/6] [Update] Terminology Change "whitelist" to "allowlist" --- lib/fastclick.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/fastclick.js b/lib/fastclick.js index 86bf83e0..225ff660 100644 --- a/lib/fastclick.js +++ b/lib/fastclick.js @@ -600,7 +600,7 @@ } // Prevent the actual click from going though - unless the target node is marked as requiring - // real clicks or if it is in the whitelist in which case only non-programmatic clicks are permitted. + // real clicks or if it is in the allowlist in which case only non-programmatic clicks are permitted. if (!this.needsClick(targetElement)) { event.preventDefault(); this.sendClick(targetElement, event); From f77afc87aa43fb7a89e1ed8ba20c8d1695bd95b6 Mon Sep 17 00:00:00 2001 From: Rhys Evans Date: Fri, 12 Feb 2021 15:32:38 +0000 Subject: [PATCH 6/6] RE-2264 Automatically creating CODEOWNERS file [Skip CI] --- .github/CODEOWNERS | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 .github/CODEOWNERS diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 00000000..d742a97c --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1,2 @@ +# Guessed from commit history +* @Financial-Times/apps