Skip to content

Commit 9e1a96b

Browse files
authored
don't use array.pop() unnecessarily
Improves rgb(a)/hsl(a) parsing performance by ~10% (on a Node v8.10 benchmark).
1 parent 0d37986 commit 9e1a96b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

csscolorparser.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ function parseCSSColor(css_str) {
165165
switch (fname) {
166166
case 'rgba':
167167
if (params.length !== 4) return null;
168-
alpha = parse_css_float(params.pop());
168+
alpha = parse_css_float(params[params.length - 1]);
169169
// Fall through.
170170
case 'rgb':
171171
if (params.length !== 3) return null;
@@ -175,7 +175,7 @@ function parseCSSColor(css_str) {
175175
alpha];
176176
case 'hsla':
177177
if (params.length !== 4) return null;
178-
alpha = parse_css_float(params.pop());
178+
alpha = parse_css_float(params[params.length - 1]);
179179
// Fall through.
180180
case 'hsl':
181181
if (params.length !== 3) return null;

0 commit comments

Comments
 (0)