Skip to content

Commit 0bdb046

Browse files
WIP: Update penthouse to 1.1
1 parent c5e0ebc commit 0bdb046

File tree

4 files changed

+5
-10
lines changed

4 files changed

+5
-10
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ Upgrade instructions from each version are included below.
1717
Add `critical-path-css-rails` to your Gemfile:
1818

1919
```
20-
gem 'critical-path-css-rails', '~> 1.0.0'
20+
gem 'critical-path-css-rails', '~> 2.0.0'
2121
```
2222

2323
Download and install by running:
@@ -110,7 +110,7 @@ Careful use of these methods allows the developer to generate critical path CSS
110110

111111
A user can use these methods to [dynamically generate critical path CSS](https://gist.github.com/taranda/1597e97ccf24c978b59aef9249666c77) without using the `rake critical_path_css:generate` rake task and without hardcoding the application's routes into `config/critical_path_css.yml`. See [this Gist](https://gist.github.com/taranda/1597e97ccf24c978b59aef9249666c77) for an example of such an implementation.
112112

113-
## Upgrading from version 0.X.X to 1.0.0
113+
## Upgrading from version 0.X.X to 1.0.0 or later
114114
To maintain the latest version of Penthouse, this gem now depends on NodeJS and NVM to be installed on the system.
115115

116116
## Upgrading from a version earlier than 0.3.0

lib/critical_path_css/css_fetcher.rb

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,6 @@ def css_for_route(route)
4444
'renderWaitTime' => 100,
4545
# set to false to load (external) JS (default: true)
4646
'blockJSRequests' => true,
47-
# see `phantomjs --help` for the list of all available options
48-
'phantomJsOptions' => {
49-
'ignore-ssl-errors' => true,
50-
'ssl-protocol' => 'tlsv1'
51-
},
5247
'customPageHeaders' => {
5348
# use if getting compression errors like 'Data corrupted':
5449
'Accept-Encoding' => 'identity'
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
module CriticalPathCSS
22
module Rails
3-
VERSION = '1.0.1'
3+
VERSION = '2.0.0'
44
end
55
end

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
{
22
"name": "critical-path-css-rails",
3-
"version": "1.0.0",
3+
"version": "2.0.0",
44
"description": "NPM dependencies of critical-path-css-rails",
55
"private": true,
66
"directories": {
77
"lib": "lib"
88
},
99
"dependencies": {
10-
"penthouse": "=0.11.5"
10+
"penthouse": "=1.1.0"
1111
},
1212
"license": "MIT"
1313
}

0 commit comments

Comments
 (0)