Move configurations into their own class, read from a YAML file

Author: michael-misshore

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2015-09-19 12:37:55 -0500 using RuboCop version 0.34.1.
+# on 2015-10-01 20:43:37 -0500 using RuboCop version 0.34.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -9,4 +9,4 @@
 # Offense count: 2
 # Configuration parameters: AllowURI, URISchemes.
 Metrics/LineLength:
-  Max: 91
+  Max: 90

lib/critical_path_css/configuration.rb

@@ -0,0 +1,23 @@
+module CriticalPathCss
+  class Configuration
+    CONFIGURATION_FILENAME = 'critical_path_css.yml'
+
+    def initialize
+      @configurations = YAML.load_file(configuration_file_path)[Rails.env]
+    end
+
+    def routes
+      @routes ||= @configurations['routes']
+    end
+
+    def base_url
+      @base_url ||= @configurations['base_url']
+    end
+
+    private
+
+    def configuration_file_path
+      Rails.root.join('config', CONFIGURATION_FILENAME)
+    end
+  end
+end

lib/critical_path_css_rails.rb

@@ -2,13 +2,15 @@ module CriticalPathCss
   require 'phantomjs'
 
   CACHE_NAMESPACE = 'critical-path-css'
-  PENTHOUSE_PATH = "#{File.dirname(__FILE__)}/penthouse/penthouse.js"
+  PENTHOUSE_PATH  = "#{File.dirname(__FILE__)}/penthouse/penthouse.js"
 
-  def self.generate(main_css_path, base_url, routes)
+  def self.generate(main_css_path)
     full_main_css_path = "#{Rails.root}/public#{main_css_path}"
+    config = CriticalPathCss::Configuration.new(Rails.root, Rails.env)
+
+    config.routes.each do |route|
+      css = Phantomjs.run(PENTHOUSE_PATH, config.base_url + route, full_main_css_path)
 
-    routes.each do |route|
-      css = Phantomjs.run(PENTHOUSE_PATH, base_url + route, full_main_css_path)
       Rails.cache.write(route, css, namespace: CACHE_NAMESPACE)
     end
   end

lib/tasks/critical_path_css.rake

@@ -1,15 +1,10 @@
 require 'critical_path_css_rails'
 
 namespace :critical_path_css do
-  @base_url = Rails.env.production? ? 'http://example.com' : 'http://localhost:3000'
-  @routes = %w(
-    /
-  )
-
   desc 'Generate critical CSS for the routes defined'
   task generate: :environment do
-    @main_css_path = ActionController::Base.helpers.stylesheet_path('application.css').to_s
+    main_css_path = ActionController::Base.helpers.stylesheet_path('application.css').to_s
 
-    CriticalPathCss.generate(@main_css_path, @base_url, @routes)
+    CriticalPathCss.generate(main_css_path)
   end
 end