Do not add value of preceding HTTP header field if there is no value (or

only white space)

Author: sebastian-nagel

src/main/java/org/archive/format/http/HttpHeaderParser.java

@@ -301,16 +301,16 @@ public ParseState handleByte(byte b, HttpHeaderParser parser) throws HttpParseEx
 			if(isLWSP(b)) {
 				return parser.postColonState;
 			}
+			// reset previous value also in case the header value is empty
+			parser.setValueStartIdx();
 			if(b == CR) {
-				// TODO: THINK more...
 				parser.valuePreCRState = parser.postColonState;
 				return parser.valuePostCRState;
 			}
 			if(b == LF) {
 				// TODO: this is lax, is LFLF an OK terminator?
 				return parser.lineStartState;
 			}
-			parser.setValueStartIdx();
 			parser.addValueByte(b);
 			return parser.valueState;
 		}

src/test/java/org/archive/format/http/HttpResponseParserTest.java

@@ -57,4 +57,28 @@ public void testParseWithLf() throws IOException {
 
 	}
 
+	public void testParseEmptyHeaderField() throws IOException {
+
+		HttpResponseParser parser = new HttpResponseParser();
+		String message = "200 OK\r\nContent-Type: text/plain\r\nServer: \r\n\r\nHi there";
+		try {
+			HttpResponse response = 
+				parser.parse(new ByteArrayInputStream(message.getBytes(IAUtils.UTF8)));
+			assertNotNull(response);
+			HttpHeaders headers = response.getHeaders();
+			assertNotNull(headers);
+			assertEquals(2, headers.size());
+			HttpHeader header = headers.get(1);
+			assertEquals("Server",header.getName());
+			System.err.println(header.getValue());
+			assertFalse("text/plain".equals(header.getValue()));
+			TestUtils.assertStreamEquals(response, "Hi there".getBytes(IAUtils.UTF8));
+			
+		} catch (HttpParseException e) {
+			e.printStackTrace();
+			fail();
+		}
+		
+	}
+
 }