Skip to content
This repository was archived by the owner on Jul 29, 2022. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NicolasCARPi/jquery_jeditable
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: nathanvda/jquery_jeditable
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 7 commits
  • 2 files changed
  • 1 contributor

Commits on Jun 17, 2018

  1. Add option to sort select-options 

    The default option is not-sorted, which is
what it used to be long ago. Not sure what is
preferable.
    @nathanvda
    nathanvda committed Jun 17, 2018
    Configuration menu
    Copy the full SHA
    14da847 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2018

  1. Use the key to set the selected value 

    This fixes #167
    @nathanvda
    nathanvda committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    6fc5db8 View commit details
    Browse the repository at this point in the history

  2. Naive/pragmatic to prevent double form submit 

    Not sure what caused it, but somehow the form.submit 
was called twice. This prevents double submits 
in a naive but effective way.
    @nathanvda
    nathanvda committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    55b00c8 View commit details
    Browse the repository at this point in the history

  3. Fix codacy remarks

    @nathanvda
    nathanvda committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    c8d53d0 View commit details
    Browse the repository at this point in the history

  4. Fix codacy remarks, try II :)

    @nathanvda
    nathanvda committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    1c72eb0 View commit details
    Browse the repository at this point in the history

  5. Codacy: fix last string quotes 

    I am leaving the console.warn in there, but we
could just as easily remove it? I know logging to
console could be a problem with IE9-10 (if it is
not opened —WTF) but I prefer to include a console
shim in my own code. And there already is another
in the code.
    @nathanvda
    nathanvda committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    e1061fd View commit details
    Browse the repository at this point in the history

  6. Fixing @NicolasCARPi’s remarks

    @nathanvda
    nathanvda committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    7ea5db4 View commit details
    Browse the repository at this point in the history
Loading