Use String.contains(String) instead of checking for index

britter · britter · commit ce1b4d824ab3 · 2015-03-28T18:11:07.000Z
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/cli/trunk@1669815 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/src/test/java/org/apache/commons/cli/OptionsTest.java b/src/test/java/org/apache/commons/cli/OptionsTest.java
@@ -147,8 +147,8 @@ public void testToString()
 
         String s = options.toString();
         assertNotNull("null string returned", s);
-        assertTrue("foo option missing", s.toLowerCase().indexOf("foo") != -1);
-        assertTrue("bar option missing", s.toLowerCase().indexOf("bar") != -1);
+        assertTrue("foo option missing", s.toLowerCase().contains("foo"));
+        assertTrue("bar option missing", s.toLowerCase().contains("bar"));
     }
 
     @Test

Original file line number	Diff line number	Diff line change
`@@ -147,8 +147,8 @@ public void testToString()`
`147`	`147`
`148`	`148`	`String s = options.toString();`
`149`	`149`	`assertNotNull("null string returned", s);`
`150`		`- assertTrue("foo option missing", s.toLowerCase().indexOf("foo") != -1);`
`151`		`- assertTrue("bar option missing", s.toLowerCase().indexOf("bar") != -1);`
	`150`	`+ assertTrue("foo option missing", s.toLowerCase().contains("foo"));`
	`151`	`+ assertTrue("bar option missing", s.toLowerCase().contains("bar"));`
`152`	`152`	`}`
`153`	`153`
`154`	`154`	`@Test`