Fixes commons-app#2062 Nearby: My position does not move (commons-app#2235)

* Add method to check if current location marker is in visible region or not

* Ignore postion track updates if current location marker is not in the visible region

* Fix unnecessary progess bar issue

Author: neslihanturan

app/src/main/java/fr/free/nrw/commons/nearby/NearbyFragment.java

@@ -444,9 +444,6 @@ private void lockNearbyView(boolean lock) {
      * @param nearbyPlacesInfo Includes nearby places list and boundary coordinates
      */
     private void updateMapFragment(boolean updateViaButton, boolean isSlightUpdate, @Nullable LatLng customLatLng, @Nullable NearbyController.NearbyPlacesInfo nearbyPlacesInfo) {
-        if (nearbyMapFragment.checkingAround) {
-            return;
-        }
         /*
         Significant update means updating nearby place markers. Slightly update means only
         updating current location marker and camera target.
@@ -456,6 +453,13 @@ private void updateMapFragment(boolean updateViaButton, boolean isSlightUpdate,
          */
         NearbyMapFragment nearbyMapFragment = getMapFragment();
 
+        if (nearbyMapFragment != null && !nearbyMapFragment.isCurrentLocationMarkerVisible()) {
+            Timber.d("Do not update the map, user is not seeing current location marker" +
+                    " means they are checking around and moving on map");
+            return;
+        }
+
+
         if (nearbyMapFragment != null && curLatLng != null) {
             hideProgressBar(); // In case it is visible (this happens, not an impossible case)
             /*

app/src/main/java/fr/free/nrw/commons/nearby/NearbyMapFragment.java

@@ -580,7 +580,7 @@ private void addMapMovementListeners() {
                             searchThisAreaModeOn = true;
                             // Lock map operations during search this area operation
                             mapboxMap.getUiSettings().setAllGesturesEnabled(false);
-                            searchThisAreaButtonProgressBar.setVisibility(View.VISIBLE);
+                            searchThisAreaButtonProgressBar.setVisibility(View.GONE);
                             fabRecenter.callOnClick();
                             searchThisAreaButton.setVisibility(View.GONE);
                             searchedAroundCurrentLocation = true;
@@ -646,6 +646,18 @@ private void addCurrentLocationMarker(MapboxMap mapboxMap) {
         mapboxMap.addPolygon(currentLocationPolygonOptions);
     }
 
+    /**
+     * Checks whether current location marker is in visible region or not
+     * @return true if point is in region
+     */
+    public boolean isCurrentLocationMarkerVisible() {
+        if (currentLocationMarker != null) {
+            return mapboxMap.getProjection().getVisibleRegion().latLngBounds.contains(currentLocationMarker.getPosition());
+        } else {
+            return false;
+        }
+    }
+
     /**
      * Adds markers for nearby places to mapbox map
      */