Add constructor to StartUploadTask that takes a contribution

Author: yuvipanda

commons/src/main/java/org/wikimedia/commons/MultipleShareActivity.java

@@ -82,7 +82,7 @@ protected Void doInBackground(Void... voids) {
                     }
                 }
 
-                StartUploadTask startUploadTask = new StartUploadTask(MultipleShareActivity.this, uploadService,  up.getFilename(),  up.getLocalUri(),  up.getDescription(), (String)up.getTag("mimeType"), Contribution.SOURCE_EXTERNAL);
+                StartUploadTask startUploadTask = new StartUploadTask(MultipleShareActivity.this, uploadService, up);
                 try {
                     Utils.executeAsyncTask(startUploadTask);
                     startUploadTask.get();

commons/src/main/java/org/wikimedia/commons/StartUploadTask.java

@@ -41,6 +41,7 @@ public StartUploadTask(Activity context, UploadService uploadService, String raw
     public StartUploadTask(Activity context, UploadService uploadService, Contribution contribution) {
         this.context = context;
         this.uploadService = uploadService;
+        this.contribution = contribution;
 
         app = (CommonsApplication)context.getApplicationContext();
     }
@@ -52,7 +53,7 @@ protected Contribution doInBackground(Void... voids) {
 
         long length;
         try {
-            if(contribution.getDataLength() == -1) {
+            if(contribution.getDataLength() <= 0) {
                 length = context.getContentResolver().openAssetFileDescriptor(contribution.getLocalUri(), "r").getLength();
                 if(length == -1) {
                     // Let us find out the long way!

commons/src/main/java/org/wikimedia/commons/contributions/Contribution.java

@@ -177,7 +177,7 @@ public void setImageUrl(String imageUrl) {
     }
 
     public Contribution() {
-        // Empty constructor for being constructed by our static methods
+        timestamp = new Date(System.currentTimeMillis());
     }
 
     public static Contribution fromCursor(Cursor cursor) {