Move UIL Image Display Options building to common method

Author: yuvipanda

commons/src/main/java/org/wikimedia/commons/MultipleUploadListFragment.java

@@ -146,13 +146,8 @@ public void afterTextChanged(Editable editable) {
     @Override
     public void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
-        uploadDisplayOptions = new DisplayImageOptions.Builder().cacheInMemory()
-                .imageScaleType(ImageScaleType.IN_SAMPLE_POWER_OF_2)
-                .displayer(new FadeInBitmapDisplayer(300))
-                .cacheInMemory()
-                .resetViewBeforeLoading().build();
-
 
+        uploadDisplayOptions = Utils.getGenericDisplayOptions().build();
     }
 
     @Override

commons/src/main/java/org/wikimedia/commons/Utils.java

@@ -2,6 +2,9 @@
 
 import android.os.AsyncTask;
 import android.os.Build;
+import com.nostra13.universalimageloader.core.DisplayImageOptions;
+import com.nostra13.universalimageloader.core.assist.ImageScaleType;
+import com.nostra13.universalimageloader.core.display.FadeInBitmapDisplayer;
 import org.apache.commons.codec.EncoderException;
 import org.apache.commons.codec.binary.Hex;
 import org.apache.commons.codec.digest.DigestUtils;
@@ -78,6 +81,18 @@ static public <T> void executeAsyncTask(AsyncTask<T, ?, ?> task,
         }
     }
 
+    private static DisplayImageOptions.Builder defaultImageOptionsBuilder;
+    public static DisplayImageOptions.Builder getGenericDisplayOptions() {
+        if(defaultImageOptionsBuilder == null) {
+            defaultImageOptionsBuilder = new DisplayImageOptions.Builder().cacheInMemory()
+                    .imageScaleType(ImageScaleType.IN_SAMPLE_POWER_OF_2)
+                    .displayer(new FadeInBitmapDisplayer(300))
+                    .cacheInMemory()
+                    .resetViewBeforeLoading();
+        }
+        return defaultImageOptionsBuilder;
+    }
+
     private static final URLCodec urlCodec = new URLCodec();
 
     public static String urlEncode(String url) {

commons/src/main/java/org/wikimedia/commons/contributions/ContributionsListFragment.java

@@ -31,6 +31,7 @@
 import org.wikimedia.commons.R;
 import org.wikimedia.commons.ShareActivity;
 import org.wikimedia.commons.UploadService;
+import org.wikimedia.commons.Utils;
 
 import java.io.File;
 import java.io.IOException;
@@ -245,12 +246,7 @@ public void onActivityCreated(Bundle savedInstanceState) {
         super.onActivityCreated(savedInstanceState);
 
         contributionsList = (GridView)getView().findViewById(R.id.contributionsList);
-        contributionDisplayOptions = new DisplayImageOptions.Builder().cacheInMemory()
-                .imageScaleType(ImageScaleType.IN_SAMPLE_POWER_OF_2)
-                .displayer(new FadeInBitmapDisplayer(300))
-                .cacheInMemory()
-                .cacheOnDisc()
-                .resetViewBeforeLoading().build();
+        contributionDisplayOptions = Utils.getGenericDisplayOptions().build();
 
         contributionsList.setOnItemClickListener((AdapterView.OnItemClickListener)getActivity());
         if(savedInstanceState != null) {

commons/src/main/java/org/wikimedia/commons/media/MediaDetailFragment.java

@@ -18,6 +18,7 @@
 import com.nostra13.universalimageloader.core.display.FadeInBitmapDisplayer;
 import org.wikimedia.commons.Media;
 import org.wikimedia.commons.R;
+import org.wikimedia.commons.Utils;
 
 public class MediaDetailFragment extends SherlockFragment {
 
@@ -86,11 +87,6 @@ public void onLoadingCancelled(String s, View view) {
     public void onActivityCreated(Bundle savedInstanceState) {
         super.onActivityCreated(savedInstanceState);
 
-        displayOptions = new DisplayImageOptions.Builder().cacheInMemory()
-                .imageScaleType(ImageScaleType.IN_SAMPLE_POWER_OF_2)
-                .displayer(new FadeInBitmapDisplayer(300))
-                .cacheInMemory()
-                .cacheOnDisc()
-                .resetViewBeforeLoading().build();
+        displayOptions = Utils.getGenericDisplayOptions().build();
     }
 }