Merge pull request commons-app#447 from neslihanturan/fixNewThemeIssues

Fix new theme issue (number 3)

Author: misaochan

app/src/main/java/fr/free/nrw/commons/SettingsActivity.java

@@ -24,7 +24,7 @@ protected void onCreate(Bundle savedInstanceState) {
         getDelegate().installViewFactory();
         getDelegate().onCreate(savedInstanceState);
         // Check prefs on every activity starts
-        if (PreferenceManager.getDefaultSharedPreferences(this).getBoolean("theme",false)) {
+        if (PreferenceManager.getDefaultSharedPreferences(this).getBoolean("theme",true)) {
             setTheme(R.style.DarkAppTheme);
         }else {
             setTheme(R.style.LightAppTheme); // default

app/src/main/java/fr/free/nrw/commons/theme/BaseActivity.java

@@ -13,7 +13,7 @@ public class BaseActivity extends Activity {
 
     @Override
     protected void onCreate(Bundle savedInstanceState) {
-        if (PreferenceManager.getDefaultSharedPreferences(this).getBoolean("theme",false)) {
+        if (PreferenceManager.getDefaultSharedPreferences(this).getBoolean("theme",true)) {
             currentTheme = true;
             setTheme(R.style.DarkAppTheme);
         }else {
@@ -26,7 +26,7 @@ protected void onCreate(Bundle savedInstanceState) {
     @Override
     protected void onResume() {
         // Restart activity if theme is changed
-        boolean newTheme = PreferenceManager.getDefaultSharedPreferences(this).getBoolean("theme",false);
+        boolean newTheme = PreferenceManager.getDefaultSharedPreferences(this).getBoolean("theme",true);
         if(currentTheme!=newTheme){ // is activity theme changed
             Intent intent = getIntent();
             finish();

app/src/main/java/fr/free/nrw/commons/theme/BaseAppCompatActivity.java

@@ -12,7 +12,7 @@ public class BaseAppCompatActivity extends AppCompatActivity {
 
     @Override
     protected void onCreate(Bundle savedInstanceState) {
-        if (PreferenceManager.getDefaultSharedPreferences(this).getBoolean("theme",false)) {
+        if (PreferenceManager.getDefaultSharedPreferences(this).getBoolean("theme",true)) {
             currentTheme = true;
             setTheme(R.style.DarkAppTheme);
         }else {
@@ -25,7 +25,7 @@ protected void onCreate(Bundle savedInstanceState) {
     @Override
     protected void onResume() {
         // Restart activity if theme is changed
-        boolean newTheme = PreferenceManager.getDefaultSharedPreferences(this).getBoolean("theme",false);
+        boolean newTheme = PreferenceManager.getDefaultSharedPreferences(this).getBoolean("theme",true);
         if(currentTheme!=newTheme){ //is activity theme changed
             Intent intent = getIntent();
             finish();

app/src/main/res/xml/preferences.xml

@@ -21,7 +21,7 @@
 
     <CheckBoxPreference
         android:title="@string/preference_theme"
-        android:defaultValue="false"
+        android:defaultValue="true"
         android:summary="@string/preference_theme_summary"
         android:key="theme" />