Skip to content

Commit caad864

Browse files
Unit tests failing (commons-app#4889)
* tests * fixed tests
1 parent ed572aa commit caad864

File tree

2 files changed

+27
-2
lines changed

2 files changed

+27
-2
lines changed

app/src/test/kotlin/fr/free/nrw/commons/leaderboard/LeaderboardFragmentUnitTests.kt

+16-1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package fr.free.nrw.commons.leaderboard
22

33
import android.accounts.Account
44
import android.content.Context
5+
import android.os.Looper.getMainLooper
56
import android.view.LayoutInflater
67
import android.view.View
78
import android.view.ViewGroup
@@ -26,11 +27,14 @@ import org.junit.Test
2627
import org.junit.runner.RunWith
2728
import org.mockito.Mock
2829
import org.mockito.Mockito.`when`
30+
import org.mockito.Mockito.doReturn
2931
import org.mockito.MockitoAnnotations
3032
import org.powermock.reflect.Whitebox
3133
import org.robolectric.Robolectric
3234
import org.robolectric.RobolectricTestRunner
3335
import org.robolectric.RuntimeEnvironment
36+
import org.robolectric.Shadows
37+
import org.robolectric.Shadows.shadowOf
3438
import org.robolectric.annotation.Config
3539
import org.robolectric.annotation.LooperMode
3640
import org.robolectric.shadows.ShadowToast
@@ -222,14 +226,25 @@ class LeaderboardFragmentUnitTests {
222226
@Test
223227
@Throws(Exception::class)
224228
fun testMenuVisibilityOverrideVisibleWithContext() {
229+
shadowOf(getMainLooper()).idle()
225230
`when`(parentView.context).thenReturn(context)
226231
val method: Method = LeaderboardFragment::class.java.getDeclaredMethod(
227232
"setMenuVisibility",
228233
Boolean::class.java
229234
)
230235
method.isAccessible = true
231236
method.invoke(fragment, true)
232-
Assert.assertEquals(ShadowToast.getTextOfLatestToast().toString(), context.getString(R.string.leaderboard_unavailable_beta))
237+
if(isBetaFlavour) {
238+
Assert.assertEquals(
239+
ShadowToast.getTextOfLatestToast().toString(),
240+
context.getString(R.string.leaderboard_unavailable_beta)
241+
)
242+
} else {
243+
Assert.assertNull(
244+
ShadowToast.getTextOfLatestToast()
245+
)
246+
}
247+
233248
}
234249

235250
}

app/src/test/kotlin/fr/free/nrw/commons/profile/achievements/AchievementsFragmentUnitTests.kt

+11-1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ import fr.free.nrw.commons.TestAppAdapter
1717
import fr.free.nrw.commons.TestCommonsApplication
1818
import fr.free.nrw.commons.auth.SessionManager
1919
import fr.free.nrw.commons.profile.ProfileActivity
20+
import fr.free.nrw.commons.utils.ConfigUtils
2021
import org.junit.Assert
2122
import org.junit.Before
2223
import org.junit.Test
@@ -372,7 +373,16 @@ class AchievementsFragmentUnitTests {
372373
)
373374
method.isAccessible = true
374375
method.invoke(fragment, true)
375-
Assert.assertEquals(ShadowToast.getTextOfLatestToast().toString(), context.getString(R.string.achievements_unavailable_beta))
376+
if(ConfigUtils.isBetaFlavour) {
377+
Assert.assertEquals(
378+
ShadowToast.getTextOfLatestToast().toString(),
379+
context.getString(R.string.achievements_unavailable_beta)
380+
)
381+
} else {
382+
Assert.assertNull(
383+
ShadowToast.getTextOfLatestToast()
384+
)
385+
}
376386
}
377387

378388
}

0 commit comments

Comments
 (0)