Merge branch 'master' into css-module-oneof-hmr

# Conflicts:
#	src/index.js

Author: ScriptedAlchemy

CHANGELOG.md

@@ -0,0 +1,11 @@
+# Change Log
+
+All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
+
+<a name="3.2.0"></a>
+# [3.2.0](https://github.com/faceyspacey/extract-css-chunks-webpack-plugin/compare/v3.1.2...v3.2.0) (2018-10-08)
+
+
+### Features
+
+* **readme:** Documenting new options that have been added ([#112](https://github.com/faceyspacey/extract-css-chunks-webpack-plugin/issues/112)) ([94ee96e](https://github.com/faceyspacey/extract-css-chunks-webpack-plugin/commit/94ee96e))

README.md

@@ -90,7 +90,10 @@ module.exports = {
           // both options are optional
           filename: "[name].css",
           chunkFilename: "[id].css",
-          hot: true // optional as the plugin cannot automatically detect if you are using HOT, not for production use
+          hot: true, // optional as the plugin cannot automatically detect if you are using HOT, not for production use
+          orderWarning: true, // Disable to remove warnings about conflicting order between imports
+          reloadAll: true, // when desperation kicks in - this is a brute force HMR flag
+          cssModules: true // if you use cssModules, this can help.
         }
     ),
   ]
@@ -194,7 +197,7 @@ module.exports = {
       }
   },
   plugins: [
-    new ExtractCssChunks({hot:true}), //if you want HMR - we try to automatically inject hot reloading but if it's not working, add it to the config
+    new ExtractCssChunks({hot:true, cssModules: true}), //if you want HMR - we try to automatically inject hot reloading but if it's not working, add it to the config
   ]
 };
 ```

package.json

@@ -1,11 +1,11 @@
 {
   "name": "extract-css-chunks-webpack-plugin",
-  "version": "0.0.0-placeholder",
+  "version": "3.2.0",
   "author": "James Gillmore <james@faceyspacey.com>",
   "contributors": [
     "Zack Jackson <zack@ScriptedAlchemy.com> (https://github.com/ScriptedAlchemy)"
   ],
-  "description": "Extract CSS from chunks into stylesheets + HMR. Supports Webpack 4",
+  "description": "Extract CSS from chunks into stylesheets + HMR. Supports Webpack 4 + SSR",
   "engines": {
     "node": ">= 6.9.0 <7.0.0 || >= 8.9.0"
   },
@@ -24,7 +24,9 @@
     "hmr",
     "universal",
     "webpack",
-    "webpack 4"
+    "webpack 4",
+    "css-hot-loader",
+    "extract-css-chunks-webpack-plugin"
   ],
   "license": "MIT",
   "scripts": {
@@ -86,7 +88,7 @@
     "nsp": "^3.1.0",
     "pre-commit": "^1.2.2",
     "prettier": "^1.11.1",
-    "standard-version": "^4.3.0",
+    "standard-version": "^4.4.0",
     "webpack": "4.8.3",
     "webpack-cli": "^2.0.13",
     "webpack-dev-server": "^3.1.1"

src/hotLoader.js

@@ -3,6 +3,7 @@ const loaderUtils = require('loader-utils');
 
 const defaultOptions = {
   fileMap: '{fileName}',
+  cssModules: true,
 };
 
 module.exports = function (content) {
@@ -13,7 +14,7 @@ module.exports = function (content) {
         loaderUtils.getOptions(this),
     );
 
-  const accept = options.cssModule ? '' : 'module.hot.accept(undefined, cssReload);';
+  const accept = options.cssModules ? '' : 'module.hot.accept(undefined, cssReload);';
   return content + `
     if(module.hot) {
       // ${Date.now()}

src/hotModuleReplacement.js

@@ -53,13 +53,15 @@ function updateCss(el, url) {
   const newEl = el.cloneNode();
 
   newEl.isLoaded = false;
+
   newEl.addEventListener('load', function () {
     newEl.isLoaded = true;
-    el.remove();
+    el.parentNode.removeChild(el);
   });
+
   newEl.addEventListener('error', function () {
     newEl.isLoaded = true;
-    el.remove();
+    el.parentNode.removeChild(el);
   });
 
   newEl.href = url + '?' + Date.now();