Skip to content

Commit 93967eb

Browse files
author
Rafael J. Staib
committed
Substitute all attr("data-*") by data("*") usages
Avoids unnecessary DOM element round-trips
1 parent 7dde49b commit 93967eb

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

src/jquery.steps.js

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -558,7 +558,7 @@
558558
case $.fn.steps.contentMode.iframe:
559559
var currentStepContent = $(".content > .body", wizard).eq(state.currentIndex);
560560
currentStepContent.html($("<iframe src=\"" + state.currentStep.contentUrl + "\" />"));
561-
currentStepContent.attr("data-loaded", "1");
561+
currentStepContent.data("loaded", "1");
562562
break;
563563

564564
case $.fn.steps.contentMode.async:
@@ -567,7 +567,7 @@
567567
$.ajax({ url: state.currentStep.contentUrl, cache: false }).done(function (data)
568568
{
569569
currentStepContent.html(data);
570-
currentStepContent.attr("data-loaded", "1");
570+
currentStepContent.data("loaded", "1");
571571
});
572572
break;
573573
}
@@ -682,11 +682,11 @@
682682
var options = wizard.data("options");
683683
var $header = $(".content > .title:eq(" + index + ")", wizard);
684684
var $content = $header.next(".body");
685-
var mode = (isNaN($content.attr("data-mode")) || Number($content.attr("data-mode")) > 2) ?
686-
$.fn.steps.contentMode.html : Number($content.attr("data-mode"));
687-
var contentUrl = (mode === $.fn.steps.contentMode.html || $content.attr("data-url") === undefined) ?
688-
"" : $content.attr("data-url");
689-
var contentLoaded = (mode !== $.fn.steps.contentMode.html && $content.attr("data-loaded") === "1");
685+
var mode = (isNaN($content.data("mode")) || Number($content.data("mode")) > 2) ?
686+
$.fn.steps.contentMode.html : Number($content.data("mode"));
687+
var contentUrl = (mode === $.fn.steps.contentMode.html || $content.data("url") === undefined) ?
688+
"" : $content.data("url");
689+
var contentLoaded = (mode !== $.fn.steps.contentMode.html && $content.data("loaded") === "1");
690690

691691
return {
692692
title: $header.html(),
@@ -702,9 +702,9 @@
702702
/// </summary>
703703
function createUniqueId(wizard)
704704
{
705-
if (wizard.attr("data-uid") === undefined)
705+
if (wizard.data("uid") === undefined)
706706
{
707-
wizard.attr("data-uid", "steps-uid-" + ++uniqueId);
707+
wizard.data("uid", "steps-uid-" + ++uniqueId);
708708
}
709709
}
710710

@@ -714,6 +714,6 @@
714714
/// <returns></returns>
715715
function getUniqueId(wizard)
716716
{
717-
return wizard.attr("data-uid");
717+
return wizard.data("uid");
718718
}
719719
})(jQuery);

0 commit comments

Comments
 (0)