keep selectors that we can't parse, to be safe

peterbe · peterbe · commit aa141bc4ff23 · 2016-01-30T22:22:56.000-05:00
diff --git a/mincss/__init__.py b/mincss/__init__.py
@@ -1 +1 @@
-__version__ = '0.10.0'
+__version__ = '0.11.0'
diff --git a/mincss/processor.py b/mincss/processor.py
@@ -495,9 +495,11 @@ def _selector_query_found(self, bodies, selector):
             except SelectorSyntaxError:
                 print('TROUBLEMAKER', file=sys.stderr)
                 print(repr(selector), file=sys.stderr)
+                return True  # better be safe and let's keep it
             except ExpressionError:
                 print('EXPRESSIONERROR', file=sys.stderr)
                 print(repr(selector), file=sys.stderr)
+                return True  # better be safe and let's keep it
         return False
 
     @staticmethod
diff --git a/tests/complex-selector.html b/tests/complex-selector.html
@@ -0,0 +1,16 @@
+<!DOCTYPE html>
+<html>
+  <head>
+    <meta charset='utf-8'>
+    <title>test page</title>
+    <style>
+      a[href^="javascript:"] { color: pink; }
+      a[href^="javascript:"]:after { content: "x"; }
+    </style>
+  </head>
+  <body>
+    <h1>h1</h1>
+    <a href="javascript:alert('hi')">actually</a>
+
+  </body>
+</html>
diff --git a/tests/test_mincss.py b/tests/test_mincss.py
@@ -320,7 +320,6 @@ def test_nth_child(self):
         url = 'file://' + html
         p = Processor()
         p.process(url)
-        # print repr(p.inlines[0].before)
         after = p.inlines[0].after
         # These mouse related one should stay, even though they're
         # currently NOT being acted upon with some input device.
@@ -334,3 +333,12 @@ def test_nth_child(self):
         ok_('div > :last-child { color: brown; }' in after)
         ok_('div > :not(p) { color: blue; }' in after)
         ok_('div > :nth-child(2) { color: red; }' in after)
+
+    def test_complex_colons_in_selector_expression(self):
+        html = os.path.join(HERE, 'complex-selector.html')
+        url = 'file://' + html
+        p = Processor()
+        p.process(url)
+        after = p.inlines[0].after
+        ok_('a[href^="javascript:"] { color: pink; }' in after)
+        ok_('a[href^="javascript:"]:after { content: "x"; }' in after)

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-__version__ = '0.10.0'`
	`1`	`+__version__ = '0.11.0'`