FIX IE: Refreshing position before focusing the element.

ph101pp · ph101pp · commit 915cdd72c128 · 2011-04-01T13:23:17.000-04:00
Prevents IE from scrolling to the focused element before it is in position.

Signed-off-by: Philipp C. Adrian &lt;philippcadrian@greenish.ch&gt;
diff --git a/ui/jquery.ui.selectmenu.js b/ui/jquery.ui.selectmenu.js
@@ -508,12 +508,14 @@ $.widget("ui.selectmenu", {
 				this.list.appendTo('body');
 			}
 			this.list.addClass(self.widgetBaseClass + '-open')
-				.attr('aria-hidden', false)
-				.find('li:not(.' + self.widgetBaseClass + '-group):eq(' + this._selectedIndex() + ') a')[0].focus();
+				.attr('aria-hidden', false);
+			// (Philipp C. Adrian) FIX IE: Refreshing position before focusing the element. 
+			// Prevents IE from scrolling to the focused element before it is in position.
+			this._refreshPosition();
+ 			this.list.find('li:not(.' + self.widgetBaseClass + '-group):eq(' + this._selectedIndex() + ') a')[0].focus();
 			if ( this.options.style == "dropdown" ) {
 				this.newelement.removeClass('ui-corner-all').addClass('ui-corner-top');
 			}
-			this._refreshPosition();
 			this._trigger("open", event, this._uiHash());
 		}
 	},

Original file line number	Diff line number	Diff line change
`@@ -508,12 +508,14 @@ $.widget("ui.selectmenu", {`
`508`	`508`	`this.list.appendTo('body');`
`509`	`509`	`}`
`510`	`510`	`this.list.addClass(self.widgetBaseClass + '-open')`
`511`		`- .attr('aria-hidden', false)`
`512`		`- .find('li:not(.' + self.widgetBaseClass + '-group):eq(' + this._selectedIndex() + ') a')[0].focus();`
	`511`	`+ .attr('aria-hidden', false);`
	`512`	`+ // (Philipp C. Adrian) FIX IE: Refreshing position before focusing the element.`
	`513`	`+ // Prevents IE from scrolling to the focused element before it is in position.`
	`514`	`+ this._refreshPosition();`
	`515`	`+ this.list.find('li:not(.' + self.widgetBaseClass + '-group):eq(' + this._selectedIndex() + ') a')[0].focus();`
`513`	`516`	`if ( this.options.style == "dropdown" ) {`
`514`	`517`	`this.newelement.removeClass('ui-corner-all').addClass('ui-corner-top');`
`515`	`518`	`}`
`516`		`- this._refreshPosition();`
`517`	`519`	`this._trigger("open", event, this._uiHash());`
`518`	`520`	`}`
`519`	`521`	`},`