Skip to content

Commit 9cf3a60

Browse files
committed
Consider data-role when picking page transition.
Re-use existing "isDialog" variable in changePage, instead of just looking at settings.role.
1 parent 705ed4f commit 9cf3a60

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

js/jquery.mobile.navigation.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -911,7 +911,7 @@
911911
// Make sure we have a transition defined.
912912
settings.transition = settings.transition
913913
|| ( ( historyDir && !activeIsInitialPage ) ? active.transition : undefined )
914-
|| ( settings.role === "dialog" ? $.mobile.defaultDialogTransition : $.mobile.defaultPageTransition );
914+
|| ( isDialog ? $.mobile.defaultDialogTransition : $.mobile.defaultPageTransition );
915915

916916
// If we're navigating back in the URL history, set reverse accordingly.
917917
settings.reverse = settings.reverse || historyDir < 0;

0 commit comments

Comments
 (0)