Draggable: Incase helper is not set to 'original' succeed with revert action even if the original element has been removed. Fixes #6871

cburgdorf · cburgdorf · commit 0ed452bf2581 · 2011-01-18T23:10:43.000+01:00
diff --git a/ui/jquery.ui.draggable.js b/ui/jquery.ui.draggable.js
@@ -192,8 +192,8 @@ $.widget("ui.draggable", $.ui.mouse, {
 			this.dropped = false;
 		}
 		
-		//if the original element is removed, don't bother to continue
-		if(!this.element[0] || !this.element[0].parentNode)
+		//if the original element is removed, don't bother to continue if helper is set to "original"
+		if((!this.element[0] || !this.element[0].parentNode) && this.options.helper == "original")
 			return false;
 
 		if((this.options.revert == "invalid" && !dropped) || (this.options.revert == "valid" && dropped) || this.options.revert === true || ($.isFunction(this.options.revert) && this.options.revert.call(this.element, dropped))) {

Original file line number	Diff line number	Diff line change
`@@ -192,8 +192,8 @@ $.widget("ui.draggable", $.ui.mouse, {`
`192`	`192`	`this.dropped = false;`
`193`	`193`	`}`
`194`	`194`
`195`		`- //if the original element is removed, don't bother to continue`
`196`		`- if(!this.element[0] \|\| !this.element[0].parentNode)`
	`195`	`+ //if the original element is removed, don't bother to continue if helper is set to "original"`
	`196`	`+ if((!this.element[0] \|\| !this.element[0].parentNode) && this.options.helper == "original")`
`197`	`197`	`return false;`
`198`	`198`
`199`	`199`	`if((this.options.revert == "invalid" && !dropped) \|\| (this.options.revert == "valid" && dropped) \|\| this.options.revert === true \|\| ($.isFunction(this.options.revert) && this.options.revert.call(this.element, dropped))) {`