Skip to content

Commit 9ef5cd0

Browse files
committed
Spinner: Use inline-element for better inline-block support. Removed float:left from input to fix input focussing in IE6.
1 parent 970befc commit 9ef5cd0

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

themes/base/jquery.ui.spinner.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
/* Spinner
22
----------------------------------*/
33
.ui-spinner { position:relative; display: inline-block; overflow: hidden; padding: 0; vertical-align: middle; height: 1.8em; }
4-
.ui-spinner-input { border: none; background: none; padding: 0; margin: .2em 0; vertical-align: middle; float: left; margin-left: .4em; margin-right: 22px; }
4+
.ui-spinner-input { border: none; background: none; padding: 0; margin: .2em 0; vertical-align: middle; margin-left: .4em; margin-right: 22px; }
55
.ui-spinner-button { width: 16px; height: 50%; font-size: .5em; padding: 0; margin: 0; z-index: 100; text-align: center; vertical-align: middle; position: absolute; cursor: default; display: block; overflow: hidden; right: 0; }
66
.ui-spinner a.ui-spinner-button { border-top: none; border-bottom: none; border-right: none; } /* more specificity required here to overide default borders */
77
.ui-spinner .ui-icon { position: absolute; margin-top: -8px; top: 50%; left: 0; } /* vertical centre icon */
88
.ui-spinner-up { top: 0; }
99
.ui-spinner-down { bottom: 0; }
1010

1111
/* TR overrides */
12-
div.ui-spinner { background: none; }
12+
span.ui-spinner { background: none; }

ui/jquery.ui.spinner.js

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -70,12 +70,6 @@ $.widget('ui.spinner', {
7070
self.hovered = false;
7171
});
7272

73-
// TODO: move to theme, ask FG how
74-
// fix inline-block issues for IE. Since IE8 supports inline-block we need to exclude it.
75-
if (!$.support.opacity && uiSpinner.css('display') == 'inline-block' && $.browser.version < 8) {
76-
uiSpinner.css('display', 'inline');
77-
}
78-
7973
this.element
8074
.bind('keydown.spinner', function(event) {
8175
if (self.options.disabled) {
@@ -206,7 +200,7 @@ $.widget('ui.spinner', {
206200
},
207201

208202
_uiSpinnerHtml: function() {
209-
return '<div role="spinbutton" class="ui-spinner ui-state-default ui-widget ui-widget-content ui-corner-all"></div>';
203+
return '<span role="spinbutton" class="ui-spinner ui-state-default ui-widget ui-widget-content ui-corner-all"></span>';
210204
},
211205

212206
_buttonHtml: function() {

0 commit comments

Comments
 (0)