Skip to content

Commit a7dae39

Browse files
zfeherzfeher
committed
Merge upstream@4.9.0
"chore(release): 4.9.0"
2 parents 017b6ca + a44cd0b commit a7dae39

File tree

7 files changed

+1672
-2079
lines changed

7 files changed

+1672
-2079
lines changed

‎.npmignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
11
example/
22
test/
33
.gitattributes
4+
.git
5+
.github
6+
coverage/

‎CHANGELOG.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,19 @@
22

33
All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
44

5+
## [4.9.0](https://github.com/faceyspacey/extract-css-chunks-webpack-plugin/compare/v4.8.0...v4.9.0) (2020-12-07)
6+
7+
8+
### Features
9+
10+
* adding federated stats ([#303](https://github.com/faceyspacey/extract-css-chunks-webpack-plugin/issues/303)) ([c17d755](https://github.com/faceyspacey/extract-css-chunks-webpack-plugin/commit/c17d75547a5efb5971d03555163ea4d685080706))
11+
* adding federated stats ([#304](https://github.com/faceyspacey/extract-css-chunks-webpack-plugin/issues/304)) ([1eab2d0](https://github.com/faceyspacey/extract-css-chunks-webpack-plugin/commit/1eab2d0b8868837de8f89f68c1ad14be741f3e78))
12+
13+
14+
### Bug Fixes
15+
16+
* Check if bestMatch exists before pop() ([#294](https://github.com/faceyspacey/extract-css-chunks-webpack-plugin/issues/294)) ([ef82da9](https://github.com/faceyspacey/extract-css-chunks-webpack-plugin/commit/ef82da9068bd699344774d39f61b7ead8cf682cb))
17+
518
### [0.9.0](https://github.com/webpack-contrib/extract-css-chunks-webpack-plugin/compare/v0.8.2...v0.9.0) (2019-12-20)
619

720

‎package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@prepair/extract-css-chunks-webpack-plugin",
3-
"version": "4.8.2",
3+
"version": "4.9.1",
44
"description": "Extract CSS from chunks into stylesheets + HMR. Supports Webpack 4 + SSR",
55
"license": "MIT",
66
"author": "James Gillmore <james@faceyspacey.com>",
@@ -70,7 +70,6 @@
7070
"loader-utils": "^2.0.0",
7171
"normalize-url": "1.9.1",
7272
"schema-utils": "^1.0.0",
73-
"webpack-external-import": "^2.2.4",
7473
"webpack-sources": "^1.1.0"
7574
},
7675
"devDependencies": {

‎src/index.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -523,6 +523,7 @@ class ExtractCssChunksPlugin {
523523
// no module found => there is a conflict
524524
// use list with fewest failed deps
525525
// and emit a warning
526+
if (!bestMatch) break;
526527
const fallbackModule = bestMatch.pop();
527528

528529
if (!this.options.ignoreOrder) {

‎test/cases/insert-function/expected/main.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -84,12 +84,12 @@
8484
/******/ // extract-css-chunks-webpack-plugin CSS loading
8585
/******/ var supportsPreload = (function() { try { return document.createElement("link").relList.supports("preload"); } catch(e) { return false; }}());
8686
/******/ var cssChunks = {"1":1};
87+
/******/ var processLinkHref = function (x) {
88+
/******/ return x;
89+
/******/ };
8790
/******/ if(installedCssChunks[chunkId]) promises.push(installedCssChunks[chunkId]);
8891
/******/ else if(installedCssChunks[chunkId] !== 0 && cssChunks[chunkId]) {
8992
/******/ promises.push(installedCssChunks[chunkId] = new Promise(function(resolve, reject) {
90-
/******/ var processLinkHref = function (x) {
91-
/******/ return x;
92-
/******/ };
9393
/******/ var href = "" + chunkId + ".css";
9494
/******/ var fullhref = processLinkHref(__webpack_require__.p + href);
9595
/******/ var existingLinkTags = document.getElementsByTagName("link");
@@ -131,7 +131,7 @@
131131
/******/ installedCssChunks[chunkId] = 0;
132132
/******/ if(supportsPreload) {
133133
/******/ var execLinkTag = document.createElement("link");
134-
/******/ execLinkTag.href = __webpack_require__.p + "" + chunkId + ".css";
134+
/******/ execLinkTag.href = processLinkHref(__webpack_require__.p + "" + chunkId + ".css");
135135
/******/ execLinkTag.rel = "stylesheet";
136136
/******/ execLinkTag.type = "text/css";
137137
/******/ document.body.appendChild(execLinkTag);

‎test/cases/insert-string/expected/main.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -84,12 +84,12 @@
8484
/******/ // extract-css-chunks-webpack-plugin CSS loading
8585
/******/ var supportsPreload = (function() { try { return document.createElement("link").relList.supports("preload"); } catch(e) { return false; }}());
8686
/******/ var cssChunks = {"1":1};
87+
/******/ var processLinkHref = function (x) {
88+
/******/ return x;
89+
/******/ };
8790
/******/ if(installedCssChunks[chunkId]) promises.push(installedCssChunks[chunkId]);
8891
/******/ else if(installedCssChunks[chunkId] !== 0 && cssChunks[chunkId]) {
8992
/******/ promises.push(installedCssChunks[chunkId] = new Promise(function(resolve, reject) {
90-
/******/ var processLinkHref = function (x) {
91-
/******/ return x;
92-
/******/ };
9393
/******/ var href = "" + chunkId + ".css";
9494
/******/ var fullhref = processLinkHref(__webpack_require__.p + href);
9595
/******/ var existingLinkTags = document.getElementsByTagName("link");
@@ -125,7 +125,7 @@
125125
/******/ installedCssChunks[chunkId] = 0;
126126
/******/ if(supportsPreload) {
127127
/******/ var execLinkTag = document.createElement("link");
128-
/******/ execLinkTag.href = __webpack_require__.p + "" + chunkId + ".css";
128+
/******/ execLinkTag.href = processLinkHref(__webpack_require__.p + "" + chunkId + ".css");
129129
/******/ execLinkTag.rel = "stylesheet";
130130
/******/ execLinkTag.type = "text/css";
131131
/******/ document.body.appendChild(execLinkTag);

0 commit comments

Comments
 (0)