Skip to content

Commit 2145536

Browse files
committed
Merge branch 'release-10.1.0' into brocs/tooltips
2 parents 37f657a + dd641e6 commit 2145536

File tree

139 files changed

+1725
-1193
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

139 files changed

+1725
-1193
lines changed

.github/CONTRIBUTING.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
[fork]: https://github.com/github/primer/fork
44
[pr]: https://github.com/github/primer/compare
5-
[style]: http://primercss.io/guidelines/
5+
[style]: http://primer.github.io/guidelines/
66

77
Hi there! We're thrilled that you'd like to contribute to this project. Your help is essential for keeping it great.
88

@@ -59,16 +59,16 @@ Good pull requests—patches, improvements, new features—are a fantastic help.
5959

6060
### Updating Primer modules
6161

62-
Anyone can open a pull request on Primer CSS. You do not need to work at GitHub or be a member of the org to open a pull request.
62+
Anyone can open a pull request on Primer. You do not need to work at GitHub or be a member of the org to open a pull request.
6363

64-
1. Fork and clone [this repository](https://github.com/primer/primer-css).
64+
1. Fork and clone [this repository](https://github.com/primer/primer).
6565
2. Configure and install the dependencies: `npm install`
6666
3. Check out the dev branch `git checkout dev`
6767
3. Create a new branch from dev `git checkout -b my-branch-name`
6868
4. Make your changes and commit them.
6969
5. Push your branch and open a pull request against `dev`. Add a comment describing your proposed changes and request a review from `@primer/ds-core`.
7070
6. Wait for CI tests to finish.
71-
- If the tests pass, you should see a status check telling you which alpha version of primer-css you can install with npm to test your work in other projects.
71+
- If the tests pass, you should see a status check telling you which alpha version of primer you can install with npm to test your work in other projects.
7272
- If the tests fail, review the logs and address any issues.
7373
- If the builds fail for any other reason (as they occasionally do), they may need to be manually restarted.
7474
7. When CI tests pass, a new npm alpha release will be posted under the CI checks, you can use this npm version for testing in your project or with a GitHub site if you are staff.

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,3 +6,4 @@ node_modules
66
build
77
_site
88
*.lerna_backup
9+
.changelog

.storybook/config.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import React from 'react'
22
import { configure, addDecorator } from '@storybook/react'
33
import { setOptions } from '@storybook/addon-options'
4-
import '../modules/primer-css/index.scss'
4+
import '../modules/primer/index.scss'
55

66
setOptions({
77
name: 'Primer',
8-
url: 'http://primercss.io/',
8+
url: 'http://primer.github.io/',
99
showDownPanel: false,
1010
})
1111

@@ -16,7 +16,6 @@ addDecorator(story => (
1616
))
1717

1818
const contexts = [
19-
require.context('.', true, /\.js$/),
2019
require.context('../modules', true, /stories.*\.js$/),
2120
]
2221

.storybook/lib/storiesFromMarkdown.js

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,23 @@ import select from 'unist-util-select'
44
import findBefore from 'unist-util-find-before'
55
import htmlToReact from 'html-to-react'
66
import parsePairs from 'parse-pairs'
7+
import React from 'react'
8+
import ReactDOMServer from 'react-dom/server'
9+
import {Octicon} from '../Octicon'
710

811
const htmlParser = new htmlToReact.Parser()
912

13+
const railsOcticonToReact = (html) => {
14+
// <%= octicon "tools" %> to <Octicon name="tools" />
15+
const octre = /<%= octicon ["']([a-z\-]+)["'][^%]*%>/gi
16+
html = html.replace(octre, (match, name) => {
17+
return ReactDOMServer.renderToStaticMarkup(<Octicon name={name} />)
18+
})
19+
return html
20+
}
21+
1022
const nodeToStory = (node, file) => {
11-
const html = node.value
23+
const html = railsOcticonToReact(node.value)
1224
const element = htmlParser.parse(html)
1325
const pairs = node.lang.replace(/^html\s*/, '')
1426
const attrs = pairs.length ? parsePairs(pairs) : {}

.travis.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,17 @@ env:
88
- secure: "EZewKKWQXmtCwPtYrPZq4OQblv2OyXR61qBIl3pOxGNVG2BCjD6VOgSaiYqkA9Qbt+ihfwQkiiLvTB68gbvRSiBFV9i+XLzKzt4S8CDI5RhTLAxZB3eQFVZRYzldchzWI4sdNhTvYS1kYXmsXQZD6vJmPSnFvOI/ddfzqvnNL4M="
99
# github
1010
- secure: "J+1oWjvvXjyrwkY/4IFWKdN/weFmQcPwlRuFG4R0Gb3rYe4nqtC9l68sJvmS8asc8dQMhOhcUZCH6sjvo7l2WD4NuK4umPSbs+rJNUsfbvH4pZjStQIj/3ll1OfQelGDWAYQWhIfciYY4F3Bp0ZWTfKOppLQ2AVIYu1fPVXDdlo="
11+
# github changelog
12+
- secure: "KcGydAqL7ryDh2rTJJB4wU8NE5BRtnrRXDEcPBScSscO3zFsHXHBDvvO04B/9hFVatXzGYXmkn+FZ0P9QikhvebzdwwyqUG2SKFiHhMvbX0m0WtAhn5NqDuKU1r5qy5YQ18r/tiLfC9GSAlEpfLAH58pwpcn8srV3Mn/yKvlrfs="
1113

1214
script:
1315
- npm test
1416

1517
after_success:
1618
# this will short-circuit the publish step if it fails to interpolate $NPM_API_KEY
1719
- npm config set "//registry.npmjs.org/:_authToken=\${NPM_API_KEY}"
18-
# copy the CHANGELOG.md primer-css for publishing
19-
- cp CHANGELOG.md modules/primer-css
20+
# copy the CHANGELOG.md primer for publishing
21+
- cp CHANGELOG.md modules/primer
2022
- script/after_success
2123

2224
deploy:

CHANGELOG.md

Lines changed: 54 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,50 @@
1-
# 10.0.0
2-
3-
### Added
4-
- New module `primer-subhead`. The Subhead is a simple header with a bottom border. It&#39;s designed to be used on settings and configuration pages.
5-
- Importing `.input-group` into `primer-forms` module.
6-
- New module `primer-branch-name` "A nice, consistent way to display branch names."
7-
- New module `primer-dropdown` "A lightweight context menu for navigation and actions."
8-
9-
### Removed
10-
- Removing `primer-cards` module.
11-
- Removing `.form-cards` styles.
12-
13-
### Changes
14-
- Moving `primer-breadcrumb` from `primer-marketing` to `primer-core`
1+
# 10.0.0 (2017-11-13)
2+
3+
#### :boom: Breaking Change
4+
* [#395](https://github.com/primer/primer/pull/395) Renaming primer-css to primer. ([@jonrohan](https://github.com/jonrohan))
5+
* [#379](https://github.com/primer/primer/pull/379) Deprecating primer-cards and form-cards. ([@jonrohan](https://github.com/jonrohan))
6+
* [#336](https://github.com/primer/primer/pull/336) Move `primer-breadcrumbs` from marketing to core ([@jonrohan]((https://github.com/jonrohan))
7+
8+
#### :rocket: Enhancement
9+
* [#371](https://github.com/primer/primer/pull/371) Add .details-reset. ([@muan](https://github.com/muan))
10+
* [#375](https://github.com/primer/primer/pull/375) New utilities & docs - fade out, hover grow, border white fade, responsive positioning, and circle. ([@sophshep](https://github.com/sophshep))
11+
* [#383](https://github.com/primer/primer/pull/383) Add 'Popover' component. ([@brandonrosage](https://github.com/brandonrosage))
12+
* [#377](https://github.com/primer/primer/pull/377) Refactor and add underline nav component. ([@ampinsk](https://github.com/ampinsk))
13+
* [#337](https://github.com/primer/primer/pull/337) Add marketing buttons to primer-marketing. ([@gladwearefriends](https://github.com/gladwearefriends))
14+
* [#342](https://github.com/primer/primer/pull/342) Add Subhead component. ([@shawnbot](https://github.com/shawnbot))
15+
* [#341](https://github.com/primer/primer/pull/341) Add branch-name component from github/github. ([@shawnbot](https://github.com/shawnbot))
16+
17+
#### :bug: Bug Fix
18+
* [#360](https://github.com/primer/primer/pull/360) Remove ::before ::after padding hack on markdown. ([@jonrohan](https://github.com/jonrohan))
19+
* [#320](https://github.com/primer/primer/pull/320) Remove -webkit-text-decoration-skip override. ([@antons](https://github.com/antons))
20+
* [#359](https://github.com/primer/primer/pull/359) Change markdown li break to handle Safari 10.x user stylesheet bug. ([@feministy](https://github.com/feministy))
21+
* [#388](https://github.com/primer/primer/pull/388) Button border-radius fix to override Chroma 62. ([@broccolini](https://github.com/broccolini))
22+
* [#307](https://github.com/primer/primer/pull/307) Do not suppress opacity transition for tooltipped-no-delay. ([@astorije](https://github.com/astorije))
23+
24+
#### :house: Internal
25+
* [#396](https://github.com/primer/primer/pull/396) Use lerna-changelog to generate a changelog. ([@jonrohan](https://github.com/jonrohan))
26+
* [#382](https://github.com/primer/primer/pull/382) Update Button docs. ([@JasonEtco](https://github.com/JasonEtco))
27+
* [#390](https://github.com/primer/primer/pull/390) Updating `storiesFromMarkdown` to read in rails Octicons helper and replace with react component. ([@jonrohan](https://github.com/jonrohan))
28+
* [#389](https://github.com/primer/primer/pull/389) Publish alpha release any time we're not on a release branch or master. ([@jonrohan](https://github.com/jonrohan))
29+
* [#384](https://github.com/primer/primer/pull/384) Add test to check for the current year in the license and source. ([@jonrohan](https://github.com/jonrohan))
30+
* [#374](https://github.com/primer/primer/pull/374) Improve Pull Request template. ([@agisilaos](https://github.com/agisilaos))
31+
32+
#### Committers: 13
33+
- Agisilaos Tsaraboulidis ([agisilaos](https://github.com/agisilaos))
34+
- Amanda Pinsker ([ampinsk](https://github.com/ampinsk))
35+
- Anton Sotkov ([antons](https://github.com/antons))
36+
- Brandon Rosage ([brandonrosage](https://github.com/brandonrosage))
37+
- Catherine Bui ([gladwearefriends](https://github.com/gladwearefriends))
38+
- Diana Mounter ([broccolini](https://github.com/broccolini))
39+
- Jason Etcovitch ([JasonEtco](https://github.com/JasonEtco))
40+
- Jon Rohan ([jonrohan](https://github.com/jonrohan))
41+
- Jérémie Astori ([astorije](https://github.com/astorije))
42+
- Mu-An ✌️ Chiou ([muan](https://github.com/muan))
43+
- Shawn Allen ([shawnbot](https://github.com/shawnbot))
44+
- Sophie Shepherd ([sophshep](https://github.com/sophshep))
45+
- liz abinante! ([feministy](https://github.com/feministy))
46+
47+
**Special thanks to @shaharke for transferring ownership of the Primer npm package to us so that we could make the rename happen!** :heart:
1548

1649
# 9.6.0
1750

@@ -39,7 +72,7 @@
3972
- Add deprecation warnings for `primer-cards` and `primer-forms/lib/form-validation.scss` #347 (these will be removed in v10.0.0)
4073

4174
### Changes
42-
- Update npm metadata for `primer-css`, `primer-core`, `primer-product`, and `primer-marketing` #328
75+
- Update npm metadata for `primer`, `primer-core`, `primer-product`, and `primer-marketing` #328
4376
- Remove `HEAD` heading from the changelog #327
4477

4578
# 9.3.0
@@ -51,7 +84,7 @@
5184
## Changes
5285
- Removes `docs` from `gitignore`
5386
- Removes the `^` from all dependencies so that we can publish exact versions
54-
- Consolidates release notes from various sources into one changelog located in `/modules/primer-css/CHANGELOG.md`
87+
- Consolidates release notes from various sources into one changelog located in `/modules/primer/CHANGELOG.md`
5588

5689
# 9.2.0
5790

@@ -62,7 +95,7 @@
6295
## Changes
6396

6497
- Remove per-module configurations (`.gitignore`, `.postcss.json`, `.stylelintrc.json`) and `CHANGELOG.md` files in #284
65-
- Replace most static `font-size`, `font-weight`, and `line-height` CSS property values with their [SCSS variable equivalents](https://github.com/primer/primer-css/blob/c9ea37316fbb73c4d9931c52b42bc197260c0bf6/modules/primer-support/lib/variables/typography.scss#L12-L33) in #252
98+
- Replace most static `font-size`, `font-weight`, and `line-height` CSS property values with their [SCSS variable equivalents](https://github.com/primer/primer/blob/c9ea37316fbb73c4d9931c52b42bc197260c0bf6/modules/primer-support/lib/variables/typography.scss#L12-L33) in #252
6699
- Refactor CI scripts to use Travis conditional deployment for release candidate and final release publish steps in #290
67100

68101
# 9.1.1
@@ -109,7 +142,7 @@ This release also includes major improvements to our Travis build scripts to aut
109142

110143
We discovered that `primer-core` specified and outdated version of `primer-base` in it's dependencies. The outdated version did not have `normalize.scss` included which could cause some issues. This has issue occurred during v7.0.0 when creating the new monorepo. Also fixes repo urls in `package.json` for individual packages.
111144

112-
See PR [#243](https://github.com/primer/primer-css/pull/243)
145+
See PR [#243](https://github.com/primer/primer/pull/243)
113146

114147
## Changes
115148

@@ -154,7 +187,7 @@ See PR [#243](https://github.com/primer/primer-css/pull/243)
154187

155188
# 8.0.0 - Imports
156189

157-
Fixes issues with the ordering of imports in each of our meta-packages. See PR [#239](https://github.com/primer/primer-css/pull/239)
190+
Fixes issues with the ordering of imports in each of our meta-packages. See PR [#239](https://github.com/primer/primer/pull/239)
158191

159192

160193
## Changes
@@ -170,7 +203,7 @@ Fixes issues with the ordering of imports in each of our meta-packages. See PR [
170203

171204
# 7.0.0 - Monorepo
172205

173-
In an effort to improve our publishing workflow we turned Primer CSS into a monorepo, made this repo the source of truth for Primer by removing Primer modules from GitHub, and setup Lerna for managing multiple packages and maintaining independent versioning for all our modules.
206+
In an effort to improve our publishing workflow we turned Primer into a monorepo, made this repo the source of truth for Primer by removing Primer modules from GitHub, and setup Lerna for managing multiple packages and maintaining independent versioning for all our modules.
174207

175208
This is exciting because:
176209

@@ -179,7 +212,7 @@ This is exciting because:
179212
- we no longer have files like package.json, scripts, and readme's in the GitHub app that don't really belong there
180213
- **we can accept pull requests from external contributors** again!
181214

182-
See PR for more details on this change: https://github.com/primer/primer-css/pull/230
215+
See PR for more details on this change: https://github.com/primer/primer/pull/230
183216

184217
## Other changes:
185218

README.md

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,37 +1,37 @@
1-
# Primer CSS
1+
# Primer
22

3-
[![npm version](http://img.shields.io/npm/v/primer-css.svg)](https://www.npmjs.org/package/primer-css)
4-
[![Build Status](https://travis-ci.org/primer/primer-css.svg?branch=master)](https://travis-ci.org/primer/primer-css)
3+
[![npm version](http://img.shields.io/npm/v/primer.svg)](https://www.npmjs.org/package/primer)
4+
[![Build Status](https://travis-ci.org/primer/primer.svg?branch=master)](https://travis-ci.org/primer/primer)
55

6-
Primer is the CSS framework that powers GitHub's front-end design. Primer CSS includes 23 packages that are grouped into 3 core meta-packages for easy install. Each package and meta-package is independently versioned and distributed via npm, so it's easy to include all or part of Primer within your own project.
6+
Primer is the design system that powers GitHub. Primer includes 23 packages that are grouped into 3 core meta-packages for easy install. Each package and meta-package is independently versioned and distributed via npm, so it's easy to include all or part of Primer within your own project.
77

88
## Packages
99

10-
The Primer CSS repo is managed as a monorepo that is composed of many npm packages.
10+
The Primer repo is managed as a monorepo that is composed of many npm packages.
1111

1212
### Core Packages
1313

1414
| Package | Version |
1515
|---|---|
16-
| **[primer-css](/modules/primer-css)** <br />Includes all 23 packages | [![npm](http://img.shields.io/npm/v/primer-css.svg)](https://www.npmjs.com/package/primer-css) |
16+
| **[primer](/modules/primer)** <br />Includes all 23 packages | [![npm](http://img.shields.io/npm/v/primer.svg)](https://www.npmjs.com/package/primer) |
1717
| [primer-core](/modules/primer-core) | [![npm](http://img.shields.io/npm/v/primer-core.svg)](https://www.npmjs.com/package/primer-core) |
1818
| [primer-product](/modules/primer-product) | [![npm](http://img.shields.io/npm/v/primer-product.svg)](https://www.npmjs.com/package/primer-product) |
1919
| [primer-marketing](/modules/primer-marketing) | [![npm](http://img.shields.io/npm/v/primer-marketing.svg)](https://www.npmjs.com/package/primer-marketing) |
2020

2121
## Install
2222

23-
This repository is distributed with [npm][npm]. After [installing npm][install-npm], you can install `primer-css` with this command.
23+
This repository is distributed with [npm][npm]. After [installing npm][install-npm], you can install `primer` with this command.
2424

2525
```sh
26-
$ npm install --save primer-css
26+
$ npm install --save primer
2727
```
2828

2929
## Usage
3030

3131
The source files included are written in [Sass][sass] (SCSS). After [installing](#install) with npm, you can add your project's `node_modules` directory to your Sass [include paths](https://github.com/sass/node-sass#includepaths) (AKA [load paths](http://technology.customink.com/blog/2014/10/09/understanding-and-using-sass-load-paths/) in Ruby), then import it like this:
3232

3333
```scss
34-
@import "primer-css/index.scss";
34+
@import "primer/index.scss";
3535
```
3636

3737
You can import individual Primer modules by installing them with npm, for instance:
@@ -46,10 +46,10 @@ Then, you would import the module with:
4646
@import "primer-navigation/index.scss";
4747
```
4848

49-
Or, while you're figuring out which modules you need, you can import them directly from the `primer-css` [`packages` directory](./packages) like so:
49+
Or, while you're figuring out which modules you need, you can import them directly from the `primer` [`packages` directory](./packages) like so:
5050

5151
```scss
52-
@import "primer-css/modules/primer-navigation/index.css";
52+
@import "primer/modules/primer-navigation/index.css";
5353
```
5454

5555

@@ -70,7 +70,7 @@ You can read more about primer in the [docs][docs].
7070
[MIT](./LICENSE) &copy; [GitHub](https://github.com/)
7171

7272
[primer]: https://github.com/primer/primer
73-
[docs]: http://primercss.io/
73+
[docs]: http://primer.github.io/
7474
[npm]: https://www.npmjs.com/
7575
[install-npm]: https://docs.npmjs.com/getting-started/installing-node
7676
[sass]: http://sass-lang.com/

lerna.json

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,17 @@
44
"modules/*",
55
"tools/*"
66
],
7+
"changelog": {
8+
"repo": "primer/primer",
9+
"labels": {
10+
"Tag: Breaking Change": ":boom: Breaking Change",
11+
"Tag: Enhancement": ":rocket: Enhancement",
12+
"Tag: Bug Fix": ":bug: Bug Fix",
13+
"Tag: Polish": ":nail_care: Polish",
14+
"Tag: Documentation": ":memo: Documentation",
15+
"Tag: Internal": ":house: Internal"
16+
},
17+
"cacheDir": ".changelog"
18+
},
719
"version": "independent"
820
}

modules/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
# Primer modules
22

3-
Primer CSS is monorepo composed of 23 packages which can be installed altogether or individually via npm. We group our packages into 3 meta-packages which you can install individually: [primer-core](primer-core), [primer-product](primer-product), and [primer-marketing](primer-marketing). Install [primer-css](primer-css) if you want to install all 23 packages.
3+
Primer is monorepo composed of 23 packages which can be installed altogether or individually via npm. We group our packages into 3 meta-packages which you can install individually: [primer-core](primer-core), [primer-product](primer-product), and [primer-marketing](primer-marketing). Install [primer](primer) if you want to install all 23 packages.

modules/primer-alerts/README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
# Primer CSS Alerts
1+
# Primer Alerts
22

33
[![npm version](http://img.shields.io/npm/v/primer-alerts.svg)](https://www.npmjs.org/package/primer-alerts)
4-
[![Build Status](https://travis-ci.org/primer/primer-css.svg?branch=master)](https://travis-ci.org/primer/primer-css)
4+
[![Build Status](https://travis-ci.org/primer/primer.svg?branch=master)](https://travis-ci.org/primer/primer)
55

66
> Flash messages, or alerts, inform users of successful or pending actions. Use them sparingly. Don’t show more than one at a time.
77
8-
This repository is a module of the full [primer-css][primer-css] repository.
8+
This repository is a module of the full [primer][primer] repository.
99

1010
## Install
1111

@@ -144,8 +144,8 @@ A flash message that is full width and removes border and border radius.
144144

145145
[MIT](./LICENSE) &copy; [GitHub](https://github.com/)
146146

147-
[primer-css]: https://github.com/primer/primer
148-
[docs]: http://primercss.io/
147+
[primer]: https://github.com/primer/primer
148+
[docs]: http://primer.github.io/
149149
[npm]: https://www.npmjs.com/
150150
[install-npm]: https://docs.npmjs.com/getting-started/installing-node
151151
[sass]: http://sass-lang.com/

0 commit comments

Comments
 (0)