Skip to content

Commit 32040ff

Browse files
authored
Rename and move color mode variables out of base package (#1462)
* Rename and move color mode variables out of base package * Create mighty-goats-teach.md * Add test to make sure support is never more than 0 * Update mighty-goats-teach.md * Update mighty-goats-teach.md
1 parent 6e47bf5 commit 32040ff

File tree

5 files changed

+10
-3
lines changed

5 files changed

+10
-3
lines changed

.changeset/mighty-goats-teach.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@primer/css": major
3+
---
4+
5+
Rename `modes.scss` file to `color-modes.scss` and move from the `base/` folder to the `support/variables` folder.

src/base/index.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
@import "../support/index.scss";
22

33
@import "./normalize.scss";
4-
@import "./modes.scss";
54
@import "./base.scss";
65
@import "./kbd.scss";
76
@import "./typography-base.scss";

src/index.scss

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@
1010
// Imports all Primer files in their intended order for easy mass-inclusion.
1111
// Should you need specific files, you can easily use separate `@import`s.
1212

13+
// CSS color variables
14+
@import "./support/variables/color-modes.scss";
15+
1316
// Global requirements
1417
@import "./core/index.scss";
1518
@import "./product/index.scss";

src/base/modes-v2.scss renamed to src/support/variables/color-modes-v2.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// EXPERIMENTAL. DO NOT USE.
22

3-
@import '../support/mixins/color-modes.scss';
3+
@import '../mixins/color-modes.scss';
44

55
@import '@primer/primitives/dist/scss/colors_v2/_light.scss';
66
@import '@primer/primitives/dist/scss/colors_v2/_dark.scss';

src/base/modes.scss renamed to src/support/variables/color-modes.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// Color modes
22

3-
@import "../support/mixins/color-modes.scss";
3+
@import "../mixins/color-modes.scss";
44

55
@import "@primer/primitives/dist/scss/colors/_light.scss";
66
@import "@primer/primitives/dist/scss/colors/_dark.scss";

0 commit comments

Comments
 (0)