Skip to content

Commit 33c9665

Browse files
authored
Merge branch 'release-10.10.0' into progress-bar
2 parents 1440c5b + 358b8b6 commit 33c9665

File tree

2 files changed

+22
-79
lines changed

2 files changed

+22
-79
lines changed

modules/primer-buttons/lib/button-group.scss

Lines changed: 16 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -5,39 +5,38 @@
55
@warn ".BtnGroup-form will be deprecated in version 11. Use .BtnGroup-parent instead.";
66

77
.BtnGroup {
8-
display: inline-block;
9-
vertical-align: middle;
10-
@include clearfix();
8+
display: inline-flex;
9+
align-items: middle;
1110

1211
// Proper spacing for multiple button groups (a la, gollum editor)
1312
+ .BtnGroup,
1413
+ .btn {
15-
margin-left: 5px;
14+
margin-left: $spacer-2;
1615
}
1716
}
1817

1918
.BtnGroup-item {
2019
position: relative;
21-
float: left;
2220
border-right-width: 0;
2321
border-radius: 0;
2422

2523
&:first-child {
26-
border-top-left-radius: 3px;
27-
border-bottom-left-radius: 3px;
24+
border-top-left-radius: $border-radius;
25+
border-bottom-left-radius: $border-radius;
2826
}
2927

3028
&:last-child {
31-
border-right-width: 1px;
32-
border-top-right-radius: 3px;
33-
border-bottom-right-radius: 3px;
29+
border-right-width: $border-width;
30+
border-top-right-radius: $border-radius;
31+
border-bottom-right-radius: $border-radius;
3432
}
3533

3634
&.selected,
3735
&:focus,
3836
&:active,
3937
&:hover {
40-
border-right-width: 1px;
38+
z-index: 1;
39+
border-right-width: $border-width;
4140

4241
+ .BtnGroup-item,
4342
+ .BtnGroup-parent .BtnGroup-item,
@@ -49,17 +48,15 @@
4948

5049
.BtnGroup-parent,
5150
.BtnGroup-form {
52-
float: left;
53-
5451
&:first-child .BtnGroup-item {
55-
border-top-left-radius: 3px;
56-
border-bottom-left-radius: 3px;
52+
border-top-left-radius: $border-radius;
53+
border-bottom-left-radius: $border-radius;
5754
}
5855

5956
&:last-child .BtnGroup-item {
60-
border-right-width: 1px;
61-
border-top-right-radius: 3px;
62-
border-bottom-right-radius: 3px;
57+
border-right-width: $border-width;
58+
border-top-right-radius: $border-radius;
59+
border-bottom-right-radius: $border-radius;
6360
}
6461

6562
.BtnGroup-item {
@@ -72,7 +69,7 @@
7269
&:active,
7370
&:hover {
7471
.BtnGroup-item {
75-
border-right-width: 1px;
72+
border-right-width: $border-width;
7673
}
7774

7875
+ .BtnGroup-item,

modules/primer-buttons/stories.js

Lines changed: 6 additions & 60 deletions
Original file line numberDiff line numberDiff line change
@@ -1,63 +1,9 @@
11
import React from 'react'
22
import { storiesOf } from '@storybook/react'
3+
import storiesFromMarkdown from '../../.storybook/lib/storiesFromMarkdown'
34

4-
storiesOf('Button', module)
5-
.add('btn', () => (
6-
<button className='btn'>Button</button>
7-
))
8-
.add('btn-primary', () => (
9-
<div className='p-4 d-flex flex-justify-between'>
10-
<button className='btn btn-primary'>Button</button>
11-
<button className='btn btn-primary hover'>hover</button>
12-
<button className='btn btn-primary focus'>focus</button>
13-
<button className='btn btn-primary selected'>selected</button>
14-
<button className='btn btn-primary disabled'>disabled</button>
15-
</div>
16-
))
17-
.add('btn-danger', () => (
18-
<div className='p-4 d-flex flex-justify-between'>
19-
<button className='btn btn-danger'>Button</button>
20-
<button className='btn btn-danger hover'>hover</button>
21-
<button className='btn btn-danger focus'>focus</button>
22-
<button className='btn btn-danger selected'>selected</button>
23-
<button className='btn btn-danger disabled'>disabled</button>
24-
</div>
25-
))
26-
.add('btn-outline', () => (
27-
<div className='p-4 d-flex flex-justify-between'>
28-
<button className='btn btn-outline'>Button</button>
29-
<button className='btn btn-outline hover'>hover</button>
30-
<button className='btn btn-outline focus'>focus</button>
31-
<button className='btn btn-outline selected'>selected</button>
32-
<button className='btn btn-outline disabled'>disabled</button>
33-
</div>
34-
))
35-
.add('btn-blue', () => (
36-
<div className='p-4 d-flex flex-justify-between'>
37-
<button className='btn btn-blue'>Button</button>
38-
<button className='btn btn-blue hover'>hover</button>
39-
<button className='btn btn-blue focus'>focus</button>
40-
<button className='btn btn-blue selected'>selected</button>
41-
<button className='btn btn-blue disabled'>disabled</button>
42-
</div>
43-
))
44-
.add('btn-purple', () => (
45-
<div className='p-4 d-flex flex-justify-between'>
46-
<button className='btn btn-purple'>Button</button>
47-
<button className='btn btn-purple hover'>hover</button>
48-
<button className='btn btn-purple focus'>focus</button>
49-
<button className='btn btn-purple selected'>selected</button>
50-
<button className='btn btn-purple disabled'>disabled</button>
51-
</div>
52-
))
53-
.add('btn-large', () => (
54-
<div className='f3 p-4'>
55-
<a className="btn btn-large btn-purple mr-6" href="#url" role="button">Large link button</a>
56-
<button className="btn btn-large" type="button">Large button button</button>
57-
</div>
58-
))
59-
.add('btn-link', () => (
60-
<div className='p-4 d-flex flex-justify-between'>
61-
<button className='btn-link'>Button</button>
62-
</div>
63-
))
5+
const stories = storiesOf('Button', module)
6+
7+
for (const {title, story} of storiesFromMarkdown(require.context('.', true, /\.md$/))) {
8+
stories.add(title, story)
9+
}

0 commit comments

Comments
 (0)