Skip to content

Commit 4b4d1cf

Browse files
authored
Merge pull request #379 from primer/deprecate-modules
Deprecating primer-cards and form-cards
2 parents ac032e1 + af82d99 commit 4b4d1cf

File tree

11 files changed

+4
-200
lines changed

11 files changed

+4
-200
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,10 @@
33
### Added
44
- New module `primer-subhead`. The Subhead is a simple header with a bottom border. It's designed to be used on settings and configuration pages.
55

6+
### Removed
7+
- Removing `primer-cards` module.
8+
- Removing `.form-cards` styles.
9+
610
# 9.6.0
711

812
### Added

modules/primer-cards/.npmignore

Lines changed: 0 additions & 2 deletions
This file was deleted.

modules/primer-cards/LICENSE

Lines changed: 0 additions & 21 deletions
This file was deleted.

modules/primer-cards/README.md

Lines changed: 0 additions & 62 deletions
This file was deleted.

modules/primer-cards/index.scss

Lines changed: 0 additions & 6 deletions
This file was deleted.

modules/primer-cards/lib/cards.scss

Lines changed: 0 additions & 6 deletions
This file was deleted.

modules/primer-cards/package.json

Lines changed: 0 additions & 41 deletions
This file was deleted.

modules/primer-css/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535
"primer-branch-name": "0.0.1",
3636
"primer-breadcrumb": "1.4.1",
3737
"primer-buttons": "2.4.1",
38-
"primer-cards": "0.5.1",
3938
"primer-core": "6.4.1",
4039
"primer-dropdown": "0.1.0",
4140
"primer-forms": "1.4.1",

modules/primer-forms/lib/form-validation.scss

Lines changed: 0 additions & 59 deletions
Original file line numberDiff line numberDiff line change
@@ -47,65 +47,6 @@ dl.form-group > dd {
4747
}
4848
}
4949

50-
// Credit cards
51-
//
52-
// A selector for credit cards. Shows all credit cards we have available and
53-
// dims the non-selected ones.
54-
55-
@warn "primer-forms: The credit cards component is being deprecated in next major version.";
56-
57-
.form-cards {
58-
height: 31px;
59-
margin: 0 0 15px;
60-
61-
.card {
62-
float: left;
63-
width: 47px;
64-
height: 31px;
65-
text-indent: -9999px;
66-
background-image: url("/images/modules/pricing/credit-cards-@1x.png");
67-
background-position: 0 0;
68-
opacity: 0.6;
69-
70-
&.visa { background-position: 0 0; }
71-
72-
&.amex { background-position: -50px 0; }
73-
74-
&.mastercard { background-position: -100px 0; }
75-
76-
&.discover { background-position: -150px 0; }
77-
78-
&.jcb { background-position: -200px 0; }
79-
80-
&.dinersclub { background-position: -250px 0; }
81-
82-
&.enabled { opacity: 1; }
83-
84-
&.disabled { opacity: 0.2; }
85-
}
86-
87-
> .cards {
88-
margin: 0;
89-
90-
> li {
91-
float: left;
92-
margin: 0 $spacer-1 0 0;
93-
list-style-type: none;
94-
95-
&.text {
96-
line-height: 31px;
97-
}
98-
}
99-
}
100-
}
101-
102-
@include retina-media-query {
103-
.form-cards > .cards .card {
104-
background-image: url("/images/modules/pricing/credit-cards-@2x.png");
105-
background-size: 300px 31px;
106-
}
107-
}
108-
10950
// Inline verification
11051
// This overrides primer's inline form stuff
11152
.status-indicator {

modules/primer-marketing/index.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
// marketing specific css modules
1818
@import "primer-marketing-type/index.scss";
19-
@import "primer-cards/index.scss";
2019
@import "primer-page-headers/index.scss";
2120
@import "primer-page-sections/index.scss";
2221
@import "primer-tables/index.scss";

0 commit comments

Comments
 (0)