Skip to content

Commit 6ae4002

Browse files
committed
Addresses @broccolini's feedback
1 parent d4e6313 commit 6ae4002

File tree

2 files changed

+15
-15
lines changed

2 files changed

+15
-15
lines changed

modules/primer-popover/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ Each of these modifiers also support a syntax for adjusting the positioning the
6161
- `.Popover-message--bottom--left`
6262
- `.Popover-message--left--bottom`
6363

64-
Lastly, there is an added `.Popover-message--lg` modifer, which Assumes a slightly wider popover message.
64+
Lastly, there is an added `.Popover-message--large` modifier, which assumes a slightly wider popover message on screens wider than 544px.
6565

6666
### Notes
6767

@@ -92,7 +92,7 @@ Defaults to caret oriented top-center.
9292
<div class="position-relative text-center">
9393
<button class="btn btn-primary">UI</button>
9494
<div class="Popover right-0 left-0">
95-
<div class="Popover-message Popover-message--lg text-left p-4 mt-2 Box box-shadow-large">
95+
<div class="Popover-message Popover-message--large text-left p-4 mt-2 Box box-shadow-large">
9696
<h4 class="mb-2">Popover heading</h4>
9797
<p>Message about this particular piece of UI.</p>
9898
<button type="submit" class="btn btn-outline mt-2 text-bold">Got it!</button>

modules/primer-popover/lib/popover.scss

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
.Popover-message {
77
position: relative;
8-
width: 235px;
8+
width: 232px;
99
margin-right: auto;
1010
margin-left: auto;
1111

@@ -22,7 +22,7 @@
2222
top: -16px;
2323
margin-left: -9px;
2424
border: $spacer-2 $border-style transparent;
25-
border-bottom-color: rgba(0, 0, 0, 0.15);
25+
border-bottom-color: $border-black-fade;
2626
}
2727

2828
&::after {
@@ -44,8 +44,8 @@
4444
}
4545

4646
&::before {
47-
bottom: -16px;
48-
border-top-color: rgba(0, 0, 0, 0.15);
47+
bottom: -$spacer-3;
48+
border-top-color: $border-black-fade;
4949
}
5050

5151
&::after {
@@ -83,7 +83,7 @@
8383

8484
&::before,
8585
&::after {
86-
left: 20px;
86+
left: $spacer-4;
8787
margin-left: 0;
8888
}
8989

@@ -121,8 +121,8 @@
121121
.Popover-message--right--top,
122122
.Popover-message--right--bottom {
123123
&::before {
124-
right: -16px;
125-
border-left-color: rgba(0, 0, 0, 0.15);
124+
right: -$spacer-3;
125+
border-left-color: $border-black-fade;
126126
}
127127

128128
&::after {
@@ -136,8 +136,8 @@
136136
.Popover-message--left--top,
137137
.Popover-message--left--bottom {
138138
&::before {
139-
left: -16px;
140-
border-right-color: rgba(0, 0, 0, 0.15);
139+
left: -$spacer-3;
140+
border-right-color: $border-black-fade;
141141
}
142142

143143
&::after {
@@ -151,7 +151,7 @@
151151
.Popover-message--left--top {
152152
&::before,
153153
&::after {
154-
top: 20px;
154+
top: $spacer-4;
155155
}
156156
}
157157

@@ -164,17 +164,17 @@
164164
}
165165

166166
&::before {
167-
bottom: 20px;
167+
bottom: $spacer-4;
168168
}
169169

170170
&::after {
171171
bottom: 21px;
172172
}
173173
}
174174

175-
.Popover-message--lg {
175+
.Popover-message--large {
176176

177177
@include breakpoint(sm) {
178-
min-width: 330px;
178+
min-width: 320px;
179179
}
180180
}

0 commit comments

Comments
 (0)