Skip to content

Commit 76bf5e5

Browse files
add missing things
1 parent 2598e4c commit 76bf5e5

File tree

6 files changed

+26
-18699
lines changed

6 files changed

+26
-18699
lines changed

modules/primer-marketing-buttons/README.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -23,22 +23,22 @@ Marketing buttons can be solid blue, outlined blue, or solid green.
2323
The solid blue and solid green buttons have more visual emphasis than the blue outlined button, therefore they should be used sparingly and only for call to actions that need emphasis.
2424

2525
```html
26-
<button class="btn-mktg" type="button">Learn more</button>
27-
<button class="btn-mktg btn-outline-mktg" type="button">Learn more</button>
28-
<button class="btn-mktg btn-primary-mktg" type="button">Sign up</button>
26+
<button class="btn-mktg mr-2" type="button">Learn more</button>
27+
<button class="btn-mktg btn-outline-mktg mr-2" type="button">Learn more</button>
28+
<button class="btn-mktg btn-primary-mktg mr-2" type="button">Sign up</button>
2929
```
3030

3131
## Sizes
3232

3333
Available in two sizes, marketing buttons have a default size and a large size.
3434

3535
```html
36-
<button class="btn-mktg" type="button">Learn more</button>
37-
<button class="btn-outline-mktg" type="button">Learn more</button>
38-
<button class="btn-primary-mktg" type="button">Sign up</button>
39-
<button class="btn-mktg btn-large-mktg" type="button">Learn more</button>
40-
<button class="btn-outline-mktg btn-large-mktg" type="button">Learn more</button>
41-
<button class="btn-primary-mktg btn-large-mktg" type="button">Sign up</button>
36+
<button class="btn-mktg mr-2" type="button">Learn more</button>
37+
<button class="btn-mktg btn-outline-mktg mr-2" type="button">Learn more</button>
38+
<button class="btn-mktg btn-primary-mktg mr-2" type="button">Sign up</button>
39+
<button class="btn-mktg btn-large-mktg mr-2" type="button">Learn more</button>
40+
<button class="btn-mktg btn-outline-mktg btn-large-mktg mr-2" type="button">Learn more</button>
41+
<button class="btn-mktg btn-primary-mktg btn-large-mktg mr-2" type="button">Sign up</button>
4242
```
4343

4444
<!-- %enddocs -->

modules/primer-marketing-buttons/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
"publish": "../../script/notify success"
3232
},
3333
"dependencies": {
34-
"primer-marketing-support": "1.5.4",
34+
"primer-marketing-support": "^1.5.4",
3535
"primer-support": "4.7.0"
3636
},
3737
"keywords": [

modules/primer-marketing-buttons/stories.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,18 @@ import { storiesOf } from '@storybook/react'
44
storiesOf('Marketing buttons', module)
55
.add('Button colors and outlined', () => (
66
<div className='p-4'>
7-
<button class="btn-mktg" type="button">Learn more</button>
8-
<button class="btn-mktg btn-outline-mktg" type="button">Learn more</button>
9-
<button class="btn-mktg btn-primary-mktg" type="button">Sign up</button>
7+
<button class="btn-mktg mr-3" type="button">Learn more</button>
8+
<button class="btn-mktg btn-outline-mktg mr-3" type="button">Learn more</button>
9+
<button class="btn-mktg btn-primary-mktg mr-3" type="button">Sign up</button>
1010
</div>
1111
))
1212
.add('Button sizes', () => (
1313
<div className='p-4'>
14-
<button class="btn-mktg" type="button">Learn more</button>
15-
<button class="btn-outline-mktg" type="button">Learn more</button>
16-
<button class="btn-primary-mktg" type="button">Sign up</button>
17-
<button class="btn-mktg btn-large-mktg" type="button">Learn more</button>
18-
<button class="btn-outline-mktg btn-large-mktg" type="button">Learn more</button>
19-
<button class="btn-primary-mktg btn-large-mktg" type="button">Sign up</button>
14+
<button class="btn-mktg mr-3" type="button">Learn more</button>
15+
<button class="btn-mktg btn-outline-mktg mr-3" type="button">Learn more</button>
16+
<button class="btn-mktg btn-primary-mktg mr-3" type="button">Sign up</button>
17+
<button class="btn-mktg btn-large-mktg mr-3" type="button">Learn more</button>
18+
<button class="btn-mktg btn-outline-mktg btn-large-mktg mr-3" type="button">Learn more</button>
19+
<button class="btn-mktg btn-primary-mktg btn-large-mktg mr-3" type="button">Sign up</button>
2020
</div>
2121
))

modules/primer-marketing-support/lib/variables.scss

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ $alt-mono-font: $mono-font;
66
$blue-450: mix($blue-500, $blue-400, 50%);
77
$green-450: mix($green-500, $green-400, 50%);
88

9+
// Animations
10+
$transition-time: 0.4s;
11+
912
// Increases primer-core scale first by 8px for spacer-7 then by 16px step increments for spacer-8 to spacer-12
1013
// i.e. After 40px, we have 48, 64, 80, 96, etc.
1114
$spacer-7: $spacer * 6; // 48px

modules/primer-marketing-support/package.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,5 +35,8 @@
3535
"functions",
3636
"variables",
3737
"scss"
38-
]
38+
],
39+
"dependencies": {
40+
"primer-support": "^4.7.0"
41+
}
3942
}

0 commit comments

Comments
 (0)