Skip to content

Commit 97cd9ee

Browse files
committed
Merge branch 'main' into vercel_action
2 parents 8e3aab0 + 12b5d9b commit 97cd9ee

File tree

7 files changed

+38
-23
lines changed

7 files changed

+38
-23
lines changed

.browserslistrc

Lines changed: 0 additions & 6 deletions
This file was deleted.

.eslintrc.json

Lines changed: 0 additions & 15 deletions
This file was deleted.

.node-version

Lines changed: 0 additions & 1 deletion
This file was deleted.
File renamed without changes.

docs/content/getting-started/theming.md

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,4 +159,18 @@ The benefit of `auto` over the `scale` variables is that `auto` variables automa
159159
<style>code { margin-right: 16px; }</style>
160160
```
161161

162-
In general, use `auto` variables if the results give enough constrast or create custom variables for further fine tuning.
162+
**Note**: If you use `stylelint`, the [`primer/no-scale-colors`](https://github.com/primer/stylelint-config-primer/tree/main/plugins#primerno-scale-colors) will fail with "[variable] is a non-functional scale color and cannot be used without being wrapped in the color-variables mixin". You can disable stylelint for this case by adding `// stylelint-disable-line`:
163+
164+
```scss
165+
.my-class {
166+
color: var(--color-auto-gray-7); // stylelint-disable-line
167+
}
168+
```
169+
170+
---
171+
172+
In general,
173+
174+
1. use [functional variables](/support/color-system) as much as possible.
175+
2. create new [custom color variables](/getting-started/theming#custom-color-variables) if there is no functional variable that fits the use case.
176+
3. as an alternaitve to custom color variables, use [`auto` variables](/getting-started/theming#auto-variables) if the results give enough constrast.

package.json

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,5 +78,28 @@
7878
"/node_modules/",
7979
"/__tests__/utils/"
8080
]
81+
},
82+
"browserslist": [
83+
"> 5%",
84+
"last 2 firefox versions",
85+
"last 2 chrome versions",
86+
"last 2 safari versions",
87+
"last 2 edge versions",
88+
"ie 11"
89+
],
90+
"eslintConfig": {
91+
"extends": [
92+
"plugin:github/internal",
93+
"plugin:github/recommended"
94+
],
95+
"env": {
96+
"es6": true,
97+
"node": true
98+
},
99+
"parserOptions": {
100+
"ecmaVersion": 2017,
101+
"requireConfigFile": false
102+
},
103+
"parser": "@babel/eslint-parser"
81104
}
82105
}
File renamed without changes.

0 commit comments

Comments
 (0)