Skip to content

Commit 9998cbb

Browse files
committed
fix up script/test-deprecations.js
1 parent 3620a1b commit 9998cbb

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

script/test-deprecations.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,7 @@ async function checkSelectorDeprecations(options = {}) {
7676
for (const {selectors = []} of deprecations) {
7777
for (const selector of selectors) {
7878
if (!removed.includes(selector)) {
79-
const error = `"${selector}" deprecated, but not removed`
80-
errors.push(error)
79+
errors.push(`"${selector}" deprecated, but not removed`)
8180
} else {
8281
console.log(`${V} selector "${selector}" is officially deprecated`)
8382
}
@@ -87,8 +86,7 @@ async function checkSelectorDeprecations(options = {}) {
8786

8887
for (const removedSelector of removed) {
8988
if (!deprecatedSelectors.includes(removedSelector)) {
90-
const error = `"${removedSelector}" has been removed, but was not listed in versionDeprecations['${currentVersion}']`
91-
errors.push(error)
89+
errors.push(`"${removedSelector}" has been removed, but was not listed in versionDeprecations['${currentVersion}']`)
9290
} else {
9391
// console.log(`${V} "${removedSelector}" removed and deprecated!`)
9492
}
@@ -128,8 +126,11 @@ async function checkVariableDeprecations(options = {}) {
128126
for (const {variables = []} of deprecations) {
129127
for (const variable of variables) {
130128
if (!removed.includes(variable)) {
131-
const error = `variable "${variable}" deprecated, but not removed`
132-
errors.push(error)
129+
if (remote[variable]) {
130+
errors.push(`variable "${variable}" deprecated, but not removed`)
131+
} else {
132+
console.log(`${I} variable "${variable}" doesn't exist in data for version: ${version}`)
133+
}
133134
} else {
134135
console.log(`${V} variable "${variable}" is officially deprecated`)
135136
}
@@ -139,8 +140,7 @@ async function checkVariableDeprecations(options = {}) {
139140

140141
for (const removedVariable of removed) {
141142
if (!deprecatedVariables.includes(removedVariable)) {
142-
const error = `"${removedVariable}" has been removed, but was not listed in versionDeprecations['${currentVersion}']`
143-
errors.push(error)
143+
errors.push(`"${removedVariable}" has been removed, but was not listed in versionDeprecations['${currentVersion}']`)
144144
} else {
145145
// console.log(`${V} "${removedVariable}" removed and deprecated!`)
146146
}

0 commit comments

Comments
 (0)