diff --git a/docs/src/stories/components/Layout/Stack.stories.jsx b/docs/src/stories/components/Layout/Stack.stories.jsx index 93203448db..396932488d 100644 --- a/docs/src/stories/components/Layout/Stack.stories.jsx +++ b/docs/src/stories/components/Layout/Stack.stories.jsx @@ -58,9 +58,9 @@ export default { }, description: `Sets the spacing gap between items. All sizes are rendered in \`rem\` units. - \`none\`: 0 -- \`condensed\`: \`var(--primer-stack-gap-condensed, 8px)\`, -- \`normal\`: \`var(--primer-stack-gap-normal, 16px)\` (default) -- \`spacious\`: \`var(--primer-stack-gap-spacious, 24px)\` (on regular viewports, otherwise it appears as \`normal\` on narrow viewports) +- \`condensed\`: \`var(--stack-gap-condensed, 8px)\`, +- \`normal\`: \`var(--stack-gap-normal, 16px)\` (default) +- \`spacious\`: \`var(--stack-gap-spacious, 24px)\` (on regular viewports, otherwise it appears as \`normal\` on narrow viewports) `, table: { @@ -120,7 +120,7 @@ This property behavior is equivalent to the \`align-items\` Flexbox property.`, control: { type: 'inline-radio', }, - description: 'Sets how items will be distributed in the stacking direction.', + description: 'Sets how items will be distributed in the stacking direction.', table: { category: 'Properties', defaultValue: { @@ -514,7 +514,7 @@ export const StackTemplate = ({ alignWrap && 'Stack--alignWrap-' + `${alignWrap}-whenRegular`, narrow_alignWrap && 'Stack--alignWrap-' + `${narrow_alignWrap}-whenNarrow`, wide_alignWrap && 'Stack--alignWrap-' + `${wide_alignWrap}-whenWide`, - + spread && 'Stack--spread-' + `${spread}-whenRegular`, narrow_spread && 'Stack--spread-' + `${narrow_spread}-whenNarrow`, wide_spread && 'Stack--spread-' + `${wide_spread}-whenWide`, @@ -531,7 +531,7 @@ export const StackTemplate = ({ //style={custom_styles} > {children} - + {!children && ( <>
1
@@ -604,4 +604,4 @@ Playground.args = { direction: "block", gap: "normal", align: "stretch", -}; \ No newline at end of file +}; diff --git a/package.json b/package.json index 343e02e44c..93bbd6e460 100644 --- a/package.json +++ b/package.json @@ -42,7 +42,7 @@ "storybook": "cd docs && yarn && yarn storybook" }, "dependencies": { - "@primer/primitives": "^7.11.5", + "@primer/primitives": "^7.11.7", "@primer/view-components": "^0.1.0" }, "devDependencies": { @@ -50,7 +50,7 @@ "@changesets/cli": "2.26.1", "@github/prettier-config": "0.0.6", "@koddsson/postcss-sass": "5.0.1", - "@primer/stylelint-config": "^12.4.0", + "@primer/stylelint-config": "0.0.0-20230420164534", "autoprefixer": "10.4.13", "chokidar-cli": "3.0.0", "cssstats": "4.0.5", diff --git a/src/autocomplete/suggester.scss b/src/autocomplete/suggester.scss index 87baf4dd9c..a7f61e0f96 100644 --- a/src/autocomplete/suggester.scss +++ b/src/autocomplete/suggester.scss @@ -11,20 +11,20 @@ margin-top: $spacer-4; list-style: none; cursor: pointer; - background: var(--color-canvas-overlay); - border: $border-width $border-style var(--color-border-default); + background: var(--overlay-bgColor, var(--color-canvas-overlay)); + border: $border-width $border-style var(--borderColor-default, var(--color-border-default)); border-radius: $border-radius; - box-shadow: var(--color-shadow-medium); + box-shadow: var(--shadow-resting-medium, var(--color-shadow-medium)); li { display: block; padding: $spacer-1 $spacer-2; font-weight: $font-weight-semibold; - border-bottom: $border-width $border-style var(--color-border-muted); + border-bottom: $border-width $border-style var(--borderColor-muted, var(--color-border-muted)); small { font-weight: $font-weight-normal; - color: var(--color-fg-muted); + color: var(--fgColor-muted, var(--color-fg-muted)); } &:last-child { @@ -39,12 +39,12 @@ } &:hover { - color: var(--color-fg-on-emphasis); + color: var(--fgColor-onEmphasis, var(--color-fg-on-emphasis)); text-decoration: none; - background: var(--color-accent-emphasis); + background: var(--bgColor-accent-emphasis, var(--color-accent-emphasis)); small { - color: var(--color-fg-on-emphasis); + color: var(--fgColor-onEmphasis, var(--color-fg-on-emphasis)); } .octicon { @@ -54,12 +54,12 @@ &[aria-selected='true'], &.navigation-focus { - color: var(--color-fg-on-emphasis); + color: var(--fgColor-onEmphasis, var(--color-fg-on-emphasis)); text-decoration: none; - background: var(--color-accent-emphasis); + background: var(--bgColor-accent-emphasis, var(--color-accent-emphasis)); small { - color: var(--color-fg-on-emphasis); + color: var(--fgColor-onEmphasis, var(--color-fg-on-emphasis)); } .octicon { diff --git a/src/avatars/avatar-parent-child.scss b/src/avatars/avatar-parent-child.scss index e3185f8068..01a5c7127e 100644 --- a/src/avatars/avatar-parent-child.scss +++ b/src/avatars/avatar-parent-child.scss @@ -10,8 +10,8 @@ position: absolute; right: -15%; bottom: -9%; - background-color: var(--color-canvas-default); // For transparent backgrounds + background-color: var(--bgColor-default, var(--color-canvas-default)); // For transparent backgrounds // stylelint-disable-next-line primer/borders border-radius: $border-radius-1; - box-shadow: var(--color-avatar-child-shadow); + box-shadow: var(--avatar-shadow, var(--color-avatar-child-shadow)); } diff --git a/src/avatars/circle-badge.scss b/src/avatars/circle-badge.scss index 657bbc931a..63032cfb63 100644 --- a/src/avatars/circle-badge.scss +++ b/src/avatars/circle-badge.scss @@ -4,9 +4,9 @@ display: flex; align-items: center; justify-content: center; - background-color: var(--color-canvas-default); + background-color: var(--bgColor-default, var(--color-canvas-default)); border-radius: 50%; - box-shadow: var(--color-shadow-medium); + box-shadow: var(--shadow-resting-medium, var(--color-shadow-medium)); } .CircleBadge-icon { @@ -46,7 +46,7 @@ width: 100%; content: ''; // stylelint-disable-next-line primer/borders - border-bottom: 2px dashed var(--color-border-default); + border-bottom: 2px dashed var(--borderColor-default, var(--color-border-default)); } .CircleBadge { diff --git a/src/base/base.scss b/src/base/base.scss index c12269ed19..dbf662b2c2 100644 --- a/src/base/base.scss +++ b/src/base/base.scss @@ -16,12 +16,12 @@ body { font-family: $body-font; font-size: var(--body-font-size, $body-font-size); line-height: $body-line-height; - color: var(--color-fg-default); - background-color: var(--color-canvas-default); + color: var(--fgColor-default, var(--color-fg-default)); + background-color: var(--bgColor-default, var(--color-canvas-default)); } a { - color: var(--color-accent-fg); + color: var(--fgColor-accent, var(--color-accent-fg)); text-decoration: none; &:hover { @@ -46,7 +46,7 @@ label { // Custom styling for HTML5 validation bubbles (WebKit only) ::placeholder { - color: var(--color-fg-subtle); + color: var(--fgColor-muted, var(--color-fg-subtle)); opacity: 1; // override opacity in normalize.css } @@ -61,7 +61,7 @@ hr, overflow: hidden; background: transparent; border: 0; - border-bottom: $border-width $border-style var(--color-border-muted); + border-bottom: $border-width $border-style var(--borderColor-muted, var(--color-border-muted)); @include clearfix(); } diff --git a/src/base/kbd.scss b/src/base/kbd.scss index f6801b920d..0905245406 100644 --- a/src/base/kbd.scss +++ b/src/base/kbd.scss @@ -7,12 +7,12 @@ kbd { font: 11px $mono-font; // stylelint-disable-next-line primer/typography line-height: 10px; - color: var(--color-fg-default); + color: var(--fgColor-default, var(--color-fg-default)); vertical-align: middle; - background-color: var(--color-canvas-subtle); + background-color: var(--bgColor-muted, var(--color-canvas-subtle)); // stylelint-disable-next-line primer/borders - border: $border-style $border-width var(--color-neutral-muted); - border-bottom-color: var(--color-neutral-muted); + border: $border-style $border-width var(--borderColor-neutral-muted, var(--color-neutral-muted)); + border-bottom-color: var(--borderColor-neutral-muted, var(--color-neutral-muted)); border-radius: $border-radius; // stylelint-disable-next-line primer/box-shadow box-shadow: inset 0 -1px 0 var(--color-neutral-muted); diff --git a/src/box/box-overlay.scss b/src/box/box-overlay.scss index ed8f273364..5a82a501be 100644 --- a/src/box/box-overlay.scss +++ b/src/box/box-overlay.scss @@ -3,9 +3,9 @@ width: 448px; margin-right: auto; margin-left: auto; - background-color: var(--color-canvas-default); + background-color: var(--bgColor-default, var(--color-canvas-default)); background-clip: padding-box; - border-color: var(--color-border-default); + border-color: var(--borderColor-default, var(--color-border-default)); // stylelint-disable-next-line primer/box-shadow box-shadow: 0 0 18px rgba(0, 0, 0, 0.4); @@ -36,7 +36,7 @@ .help { padding-top: $spacer-2; margin: 0; - color: var(--color-fg-muted); + color: var(--fgColor-muted, var(--color-fg-muted)); text-align: center; } } diff --git a/src/branch-name/branch-name.scss b/src/branch-name/branch-name.scss index 600e99b8a9..c18c746e50 100644 --- a/src/branch-name/branch-name.scss +++ b/src/branch-name/branch-name.scss @@ -7,25 +7,25 @@ // stylelint-disable-next-line primer/spacing padding: 2px 6px; font: 12px $mono-font; - color: var(--color-fg-muted); + color: var(--fgColor-muted, var(--color-fg-muted)); word-break: break-all; - background-color: var(--color-accent-subtle); + background-color: var(--bgColor-accent-muted, var(--color-accent-subtle)); border-radius: $border-radius; .octicon { // stylelint-disable-next-line primer/spacing margin: 1px -2px 0 0; - color: var(--color-fg-muted); + color: var(--fgColor-muted, var(--color-fg-muted)); } } // When a branch name is a link a.branch-name { - color: var(--color-accent-fg); - background-color: var(--color-accent-subtle); + color: var(--fgColor-accent, var(--color-accent-fg)); + background-color: var(--bgColor-accent-muted, var(--color-accent-subtle)); .octicon { - color: var(--color-accent-fg); + color: var(--fgColor-accent, var(--color-accent-fg)); } } diff --git a/src/buttons/button.scss b/src/buttons/button.scss index 27563db247..d1c9dd55f2 100644 --- a/src/buttons/button.scss +++ b/src/buttons/button.scss @@ -36,7 +36,7 @@ .octicon { margin-right: $spacer-1; - color: var(--color-fg-muted); + color: var(--fgColor-muted, var(--color-fg-muted)); vertical-align: text-bottom; &:only-child { @@ -50,7 +50,7 @@ color: inherit; text-shadow: none; vertical-align: top; - background-color: var(--color-btn-counter-bg); + background-color: var(--buttonCounter-default-bgColor-rest, var(--color-btn-counter-bg)); } .dropdown-caret { @@ -63,41 +63,41 @@ .btn { color: var(--color-btn-text); - background-color: var(--color-btn-bg); - border-color: var(--color-btn-border); - box-shadow: var(--color-btn-shadow), var(--color-btn-inset-shadow); + background-color: var(--button-default-bgColor-rest, var(--color-btn-bg)); + border-color: var(--button-default-borderColor-rest, var(--color-btn-border)); + box-shadow: var(--button-default-shadow-resting, var(--color-btn-shadow)), var(--button-default-shadow-inset, var(--color-btn-inset-shadow)); transition: 80ms cubic-bezier(0.33, 1, 0.68, 1); transition-property: color, background-color, box-shadow, border-color; &:hover, &.hover, [open] > & { - background-color: var(--color-btn-hover-bg); - border-color: var(--color-btn-hover-border); + background-color: var(--button-default-bgColor-hover, var(--color-btn-hover-bg)); + border-color: var(--button-default-borderColor-hover, var(--color-btn-hover-border)); transition-duration: 0.1s; } &:active { - background-color: var(--color-btn-active-bg); - border-color: var(--color-btn-active-border); + background-color: var(--button-default-bgColor-active, var(--color-btn-active-bg)); + border-color: var(--button-default-borderColor-active, var(--color-btn-active-border)); transition: none; } &.selected, &[aria-selected='true'] { - background-color: var(--color-btn-selected-bg); - box-shadow: var(--color-primer-shadow-inset); + background-color: var(--button-default-bgColor-selected, var(--color-btn-selected-bg)); + box-shadow: var(--shadow-inset, var(--color-primer-shadow-inset)); } &:disabled, &.disabled, &[aria-disabled='true'] { - color: var(--color-primer-fg-disabled); - background-color: var(--color-btn-bg); - border-color: var(--color-btn-border); + color: var(--fgColor-disabled, var(--color-primer-fg-disabled)); + background-color: var(--button-default-bgColor-rest, var(--color-btn-bg)); + border-color: var(--button-default-borderColor-rest, var(--color-btn-border)); .octicon { - color: var(--color-primer-fg-disabled); + color: var(--fgColor-disabled, var(--color-primer-fg-disabled)); } } } @@ -105,16 +105,16 @@ // Primary button .btn-primary { - color: var(--color-btn-primary-text); - background-color: var(--color-btn-primary-bg); - border-color: var(--color-btn-primary-border); - box-shadow: var(--color-btn-primary-shadow), var(--color-btn-primary-inset-shadow); + color: var(--button-primary-fgColor-rest, var(--color-btn-primary-text)); + background-color: var(--button-primary-bgColor-rest, var(--color-btn-primary-bg)); + border-color: var(--button-primary-borderColor-rest, var(--color-btn-primary-border)); + box-shadow: var(--shadow-resting-small, var(--color-btn-primary-shadow)), var(--shadow-highlight, var(--color-btn-primary-inset-shadow)); &:hover, &.hover, [open] > & { - background-color: var(--color-btn-primary-hover-bg); - border-color: var(--color-btn-primary-hover-border); + background-color: var(--button-primary-bgColor-hover, var(--color-btn-primary-hover-bg)); + border-color: var(--button-primary-borderColor-hover, var(--color-btn-primary-hover-border)); } // fallback :focus state @@ -136,29 +136,29 @@ &:active, &.selected, &[aria-selected='true'] { - background-color: var(--color-btn-primary-selected-bg); - box-shadow: var(--color-btn-primary-selected-shadow); + background-color: var(--button-primary-bgColor-active, var(--color-btn-primary-selected-bg)); + box-shadow: var(--button-primary-shadow-selected, var(--color-btn-primary-selected-shadow)); } &:disabled, &.disabled, &[aria-disabled='true'] { - color: var(--color-btn-primary-disabled-text); - background-color: var(--color-btn-primary-disabled-bg); - border-color: var(--color-btn-primary-disabled-border); + color: var(--button-primary-fgColor-disabled, var(--color-btn-primary-disabled-text)); + background-color: var(--button-primary-bgColor-disabled, var(--color-btn-primary-disabled-bg)); + border-color: var(--button-primary-borderColor-disabled, var(--color-btn-primary-disabled-border)); .octicon { - color: var(--color-btn-primary-disabled-text); + color: var(--button-primary-fgColor-disabled, var(--color-btn-primary-disabled-text)); } } .Counter { color: inherit; - background-color: var(--color-btn-primary-counter-bg); + background-color: var(--buttonCounter-primary-bgColor-rest, var(--color-btn-primary-counter-bg)); } .octicon { - color: var(--color-btn-primary-icon); + color: var(--button-primary-iconColor-rest, var(--color-btn-primary-icon)); } } @@ -185,17 +185,17 @@ a.btn-primary { // Outline button .btn-outline { - color: var(--color-btn-outline-text); + color: var(--button-outline-fgColor-rest, var(--color-btn-outline-text)); &:hover, [open] > & { - color: var(--color-btn-outline-hover-text); - background-color: var(--color-btn-outline-hover-bg); - border-color: var(--color-btn-outline-hover-border); - box-shadow: var(--color-btn-outline-hover-shadow), var(--color-btn-outline-hover-inset-shadow); + color: var(--button-outline-fgColor-hover, var(--color-btn-outline-hover-text)); + background-color: var(--button-outline-bgColor-hover, var(--color-btn-outline-hover-bg)); + border-color: var(--button-outline-borderColor-hover, var(--color-btn-outline-hover-border)); + box-shadow: var(--shadow-resting-small, var(--color-btn-outline-hover-shadow)), var(--shadow-highlight, var(--color-btn-outline-hover-inset-shadow)); .Counter { - background-color: var(--color-btn-outline-hover-counter-bg); + background-color: var(--buttonCounter-outline-bgColor-hover, var(--color-btn-outline-hover-counter-bg)); } .octicon { @@ -206,10 +206,10 @@ a.btn-primary { &:active, &.selected, &[aria-selected='true'] { - color: var(--color-btn-outline-selected-text); - background-color: var(--color-btn-outline-selected-bg); - border-color: var(--color-btn-outline-selected-border); - box-shadow: var(--color-btn-outline-selected-shadow); + color: var(--button-outline-fgColor-active, var(--color-btn-outline-selected-text)); + background-color: var(--button-outline-bgColor-active, var(--color-btn-outline-selected-bg)); + border-color: var(--button-outline-borderColor-active, var(--color-btn-outline-selected-border)); + box-shadow: var(--button-outline-shadow-selected, var(--color-btn-outline-selected-shadow)); // fallback :focus state &:focus { @@ -231,76 +231,76 @@ a.btn-primary { &:disabled, &.disabled, &[aria-disabled='true'] { - color: var(--color-btn-outline-disabled-text); - background-color: var(--color-btn-outline-disabled-bg); - border-color: var(--color-btn-border); + color: var(--button-outline-fgColor-disabled, var(--color-btn-outline-disabled-text)); + background-color: var(--button-outline-bgColor-disabled, var(--color-btn-outline-disabled-bg)); + border-color: var(--button-default-borderColor-rest, var(--color-btn-border)); box-shadow: none; .Counter { - background-color: var(--color-btn-outline-disabled-counter-bg); + background-color: var(--buttonCounter-outline-bgColor-disabled, var(--color-btn-outline-disabled-counter-bg)); } } .Counter { color: inherit; - background-color: var(--color-btn-outline-counter-bg); + background-color: var(--buttonCounter-outline-bgColor-rest, var(--color-btn-outline-counter-bg)); } } // Danger button .btn-danger { - color: var(--color-btn-danger-text); + color: var(--button-danger-fgColor-rest, var(--color-btn-danger-text)); .octicon { - color: var(--color-btn-danger-icon); + color: var(--button-danger-iconColor-rest, var(--color-btn-danger-icon)); } &:hover, [open] > & { - color: var(--color-btn-danger-hover-text); - background-color: var(--color-btn-danger-hover-bg); - border-color: var(--color-btn-danger-hover-border); - box-shadow: var(--color-btn-danger-hover-shadow), var(--color-btn-danger-hover-inset-shadow); + color: var(--button-danger-fgColor-hover, var(--color-btn-danger-hover-text)); + background-color: var(--button-danger-bgColor-hover, var(--color-btn-danger-hover-bg)); + border-color: var(--button-outline-borderColor-hover, var(--color-btn-danger-hover-border)); + box-shadow: var(--shadow-resting-small, var(--color-btn-danger-hover-shadow)), var(--shadow-highlight, var(--color-btn-danger-hover-inset-shadow)); .Counter { - background-color: var(--color-btn-danger-hover-counter-bg); + background-color: var(--buttonCounter-danger-bgColor-hover, var(--color-btn-danger-hover-counter-bg)); } .octicon { - color: var(--color-btn-danger-hover-icon); + color: var(--button-danger-iconColor-hover, var(--color-btn-danger-hover-icon)); } } &:active, &.selected, &[aria-selected='true'] { - color: var(--color-btn-danger-selected-text); - background-color: var(--color-btn-danger-selected-bg); - border-color: var(--color-btn-danger-selected-border); - box-shadow: var(--color-btn-danger-selected-shadow); + color: var(--button-danger-fgColor-active, var(--color-btn-danger-selected-text)); + background-color: var(--button-danger-bgColor-active, var(--color-btn-danger-selected-bg)); + border-color: var(--button-danger-borderColor-active, var(--color-btn-danger-selected-border)); + box-shadow: var(--button-danger-shadow-selected, var(--color-btn-danger-selected-shadow)); } &:disabled, &.disabled, &[aria-disabled='true'] { - color: var(--color-btn-danger-disabled-text); - background-color: var(--color-btn-danger-disabled-bg); - border-color: var(--color-btn-border); + color: var(--button-danger-fgColor-disabled, var(--color-btn-danger-disabled-text)); + background-color: var(--button-danger-bgColor-disabled, var(--color-btn-danger-disabled-bg)); + border-color: var(--button-default-borderColor-rest, var(--color-btn-border)); box-shadow: none; .Counter { - background-color: var(--color-btn-danger-disabled-counter-bg); + background-color: var(--buttonCounter-danger-bgColor-disabled, var(--color-btn-danger-disabled-counter-bg)); } .octicon { - color: var(--color-btn-danger-disabled-text); + color: var(--button-danger-fgColor-disabled, var(--color-btn-danger-disabled-text)); } } .Counter { color: inherit; - background-color: var(--color-btn-danger-counter-bg); + background-color: var(--buttonCounter-danger-bgColor-rest, var(--color-btn-danger-counter-bg)); } } diff --git a/src/buttons/misc.scss b/src/buttons/misc.scss index 328b2fe27a..ef5fd41e8b 100644 --- a/src/buttons/misc.scss +++ b/src/buttons/misc.scss @@ -7,7 +7,7 @@ display: inline-block; padding: 0; font-size: inherit; - color: var(--color-accent-fg); + color: var(--fgColor-accent, var(--color-accent-fg)); text-decoration: none; white-space: nowrap; cursor: pointer; @@ -24,7 +24,7 @@ &[aria-disabled='true'] { &, &:hover { - color: var(--color-primer-fg-disabled); + color: var(--fgColor-disabled, var(--color-primer-fg-disabled)); cursor: default; } } @@ -42,7 +42,7 @@ // // Typically used as a "cancel" button next to a .btn .btn-invisible { - color: var(--color-accent-fg); + color: var(--fgColor-accent, var(--color-accent-fg)); background-color: transparent; // Reset default gradient backgrounds and colors border: 0; border-radius: $border-radius; @@ -50,8 +50,8 @@ &:hover, &.zeroclipboard-is-hover { - color: var(--color-accent-fg); - background-color: var(--color-btn-hover-bg); + color: var(--fgColor-accent, var(--color-accent-fg)); + background-color: var(--button-default-bgColor-hover, var(--color-btn-hover-bg)); outline: none; box-shadow: none; } @@ -60,21 +60,21 @@ &.selected, &[aria-selected='true'], &.zeroclipboard-is-active { - color: var(--color-accent-fg); + color: var(--fgColor-accent, var(--color-accent-fg)); background: none; - border-color: var(--color-btn-active-border); + border-color: var(--button-default-borderColor-active, var(--color-btn-active-border)); @include focusOutline; } &:active &.zeroclipboard-is-active { - background-color: var(--color-btn-selected-bg); + background-color: var(--button-default-bgColor-selected, var(--color-btn-selected-bg)); } &:disabled, &.disabled, &[aria-disabled='true'] { - color: var(--color-primer-fg-disabled); + color: var(--fgColor-disabled, var(--color-primer-fg-disabled)); background-color: transparent; } } @@ -89,7 +89,7 @@ // stylelint-disable-next-line primer/spacing margin-left: 5px; line-height: $lh-condensed-ultra; - color: var(--color-fg-muted); + color: var(--fgColor-muted, var(--color-fg-muted)); vertical-align: middle; // For `