From 40aad6715e3f157a332d6ddf6a79a289d84f5dad Mon Sep 17 00:00:00 2001 From: Shawn Allen Date: Tue, 19 Jun 2018 14:48:46 -0700 Subject: [PATCH 1/3] no border-right on last avatar in AvatarStack --- modules/primer-avatars/lib/avatar-stack.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/modules/primer-avatars/lib/avatar-stack.scss b/modules/primer-avatars/lib/avatar-stack.scss index 285b85077f..67468d12a1 100644 --- a/modules/primer-avatars/lib/avatar-stack.scss +++ b/modules/primer-avatars/lib/avatar-stack.scss @@ -88,6 +88,7 @@ } &:last-child { + border-right: 0; z-index: 1; } From 551481fb24668bce634be6cbc681244bfafdef25 Mon Sep 17 00:00:00 2001 From: Shawn Allen Date: Tue, 19 Jun 2018 14:49:15 -0700 Subject: [PATCH 2/3] add (visual) test cases for AvatarStack on blue bg --- modules/primer-avatars/stories.js | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/modules/primer-avatars/stories.js b/modules/primer-avatars/stories.js index e969727a1c..564fefffac 100644 --- a/modules/primer-avatars/stories.js +++ b/modules/primer-avatars/stories.js @@ -60,7 +60,23 @@ storiesOf('Avatars', module) Uncle Cat - + +)) +.add('AvatarStack on blue background', () => ( +
+
+
+ + @github + +
+
+
+
+ Uncle Cat + Uncle Cat +
+
)) .add('CircleBadge--small', () => ( From e0ef76f18416c14a29a80e76cd4f16facfe2c46b Mon Sep 17 00:00:00 2001 From: Shawn Allen Date: Tue, 19 Jun 2018 15:03:28 -0700 Subject: [PATCH 3/3] fix property order --- modules/primer-avatars/lib/avatar-stack.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/primer-avatars/lib/avatar-stack.scss b/modules/primer-avatars/lib/avatar-stack.scss index 67468d12a1..913a1c4c75 100644 --- a/modules/primer-avatars/lib/avatar-stack.scss +++ b/modules/primer-avatars/lib/avatar-stack.scss @@ -88,8 +88,8 @@ } &:last-child { - border-right: 0; z-index: 1; + border-right: 0; } // stylelint-disable selector-max-type