Remove globals that are now unnecessary thanks to the use of various ESLint environments (e.g. Node, ShellJS, Jasmine)

Snuffleupagus · Snuffleupagus · commit c850968fa733 · 2016-12-16T21:09:55.000+01:00
diff --git a/examples/mobile-viewer/viewer.js b/examples/mobile-viewer/viewer.js
@@ -12,8 +12,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
-/* globals PDFJS, Promise */
+/* globals PDFJS */
 
 'use strict';
 
diff --git a/extensions/chromium/options/options.js b/extensions/chromium/options/options.js
@@ -13,7 +13,7 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 See the License for the specific language governing permissions and
 limitations under the License.
 */
-/* globals chrome, Promise */
+/* globals chrome */
 
 'use strict';
 var storageAreaName = chrome.storage.sync ? 'sync' : 'local';
diff --git a/external/builder/builder.js b/external/builder/builder.js
@@ -1,5 +1,3 @@
-/* globals cp, ls, test */
-
 'use strict';
 
 var fs = require('fs'),
diff --git a/external/builder/test.js b/external/builder/test.js
@@ -1,4 +1,3 @@
-/* globals cat, cd, echo, ls */
 'use strict';
 
 require('shelljs/make');
diff --git a/external/builder/test2.js b/external/builder/test2.js
@@ -1,4 +1,3 @@
-/* globals cat, cd, echo, ls */
 'use strict';
 
 require('shelljs/make');
diff --git a/external/crlfchecker/crlfchecker.js b/external/crlfchecker/crlfchecker.js
@@ -1,5 +1,3 @@
-/* globals cat, echo, exit, ls */
-
 'use strict';
 
 function checkIfCrlfIsPresent(files) {
diff --git a/make.js b/make.js
@@ -13,8 +13,6 @@
  * limitations under the License.
  */
 /* eslint-env node, shelljs */
-/* globals cat, cd, cp, echo, env, exec, exit, find, ls, mkdir, mv, process, rm,
-           sed, target, test */
 
 'use strict';
 
diff --git a/src/core/worker.js b/src/core/worker.js
@@ -12,7 +12,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-/* globals NetworkManager, module */
+/* globals module */
 
 'use strict';
 
diff --git a/src/display/canvas.js b/src/display/canvas.js
@@ -12,7 +12,6 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-/* globals ImageData */
 
 'use strict';
 
diff --git a/src/display/font_loader.js b/src/display/font_loader.js
@@ -12,7 +12,6 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-/* globals FontFace */
 
 'use strict';
 
diff --git a/src/display/metadata.js b/src/display/metadata.js
@@ -12,7 +12,6 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-/* globals Document */
 
 'use strict';
 
diff --git a/src/display/text_layer.js b/src/display/text_layer.js
@@ -12,7 +12,6 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-/* globals WeakMap */
 
 'use strict';
 
diff --git a/src/shared/util.js b/src/shared/util.js
@@ -12,7 +12,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-/* globals URL, global */
+/* globals global */
 
 'use strict';
 
diff --git a/test/font/jasmine-boot.js b/test/font/jasmine-boot.js
@@ -34,7 +34,7 @@
  OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
  WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
-/*globals jasmineRequire, jasmine, TestReporter */
+/* globals jasmineRequire, TestReporter */
 
 // Modified jasmine's boot.js file to load PDF.js libraries async.
 
diff --git a/test/unit/annotation_layer_spec.js b/test/unit/annotation_layer_spec.js
@@ -1,8 +1,7 @@
-/* globals expect, it, describe, Dict, Name, Annotation, AnnotationBorderStyle,
-           AnnotationBorderStyleType, AnnotationType, AnnotationFlag, PDFJS,
-           beforeEach, afterEach, stringToBytes, AnnotationFactory, Ref, isRef,
-           beforeAll, afterAll, AnnotationFieldFlag, stringToUTF8String,
-           StringStream, Lexer, Parser */
+/* globals isRef, AnnotationFactory, Dict, Name, Ref, AnnotationType,
+           AnnotationFlag, Annotation, AnnotationBorderStyle,
+           AnnotationBorderStyleType, StringStream, Lexer, Parser,
+           stringToUTF8String, AnnotationFieldFlag, PDFJS, stringToBytes */
 
 'use strict';
 
diff --git a/test/unit/api_spec.js b/test/unit/api_spec.js
@@ -1,7 +1,6 @@
-/* globals PDFJS, expect, it, describe, Promise, beforeAll,
-           InvalidPDFException, MissingPDFException, StreamType, FontType,
-           PDFDocumentProxy, PasswordException, PasswordResponses, afterAll,
-           PDFPageProxy, createPromiseCapability, afterEach */
+/* globals PDFJS, createPromiseCapability, PDFDocumentProxy,
+           InvalidPDFException, MissingPDFException, PasswordResponses,
+           PasswordException, PDFPageProxy, StreamType, FontType */
 
 'use strict';
 
diff --git a/test/unit/cff_parser_spec.js b/test/unit/cff_parser_spec.js
@@ -1,6 +1,5 @@
-/* globals describe, it, expect, beforeAll, afterAll, beforeEach, afterEach,
-           Stream, CFFParser, SEAC_ANALYSIS_ENABLED, CFFIndex, CFFStrings,
-           CFFCompiler */
+/* globals Stream, CFFParser, SEAC_ANALYSIS_ENABLED, CFFIndex, CFFParser,
+           CFFStrings, CFFCompiler */
 
 'use strict';
 
diff --git a/test/unit/cmap_spec.js b/test/unit/cmap_spec.js
@@ -1,5 +1,4 @@
-/* globals expect, it, describe, StringStream, CMapFactory, Name, CMap,
-           IdentityCMap */
+/* globals StringStream, CMapFactory, CMap, IdentityCMap, Name */
 
 'use strict';
 
diff --git a/test/unit/crypto_spec.js b/test/unit/crypto_spec.js
@@ -1,7 +1,7 @@
-/* globals expect, it, describe, calculateMD5, ARCFourCipher, Name, beforeAll,
-           CipherTransformFactory, calculateSHA256, calculateSHA384, afterAll,
-           calculateSHA512, AES128Cipher, AES256Cipher, PDF17, PDF20, Dict,
-           PasswordException, PasswordResponses, stringToBytes */
+/* globals stringToBytes, calculateMD5, ARCFourCipher, calculateSHA256,
+           calculateSHA384, calculateSHA512, AES128Cipher, AES256Cipher, PDF17,
+           PDF20, Dict, CipherTransformFactory, PasswordException,
+           PasswordResponses, Name */
 
 'use strict';
 
diff --git a/test/unit/dom_utils_spec.js b/test/unit/dom_utils_spec.js
@@ -1,5 +1,4 @@
-/* globals expect, it, describe, PDFJS, isExternalLinkTargetSet, LinkTarget,
-           getFilenameFromUrl, beforeAll, afterAll */
+/* globals getFilenameFromUrl, PDFJS, LinkTarget, isExternalLinkTargetSet */
 
 'use strict';
 
diff --git a/test/unit/evaluator_spec.js b/test/unit/evaluator_spec.js
@@ -1,5 +1,5 @@
-/* globals expect, it, describe, PartialEvaluator, StringStream, OPS,
-           OperatorList, Dict, Name, Stream, WorkerTask */
+/* globals OperatorList, WorkerTask, PartialEvaluator, StringStream, OPS, Dict,
+           Name, Stream */
 
 'use strict';
 
diff --git a/test/unit/fonts_spec.js b/test/unit/fonts_spec.js
@@ -1,4 +1,4 @@
-/* globals describe, it, expect, checkProblematicCharRanges */
+/* globals checkProblematicCharRanges */
 
 'use strict';
 
diff --git a/test/unit/function_spec.js b/test/unit/function_spec.js
@@ -1,6 +1,5 @@
-/* globals jasmine, expect, it, describe, beforeEach, isArray, StringStream,
-           PostScriptParser, PostScriptLexer, PostScriptEvaluator,
-           PostScriptCompiler*/
+/* globals isArray, StringStream, PostScriptParser, PostScriptLexer,
+           PostScriptEvaluator, PostScriptCompiler */
 
 'use strict';
 
diff --git a/test/unit/jasmine-boot.js b/test/unit/jasmine-boot.js
@@ -34,7 +34,7 @@
  OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
  WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
-/*globals jasmineRequire, jasmine, TestReporter */
+/* globals jasmineRequire, TestReporter */
 
 // Modified jasmine's boot.js file to load PDF.js libraries async.
 
diff --git a/test/unit/metadata_spec.js b/test/unit/metadata_spec.js
@@ -1,4 +1,4 @@
-/* globals expect, it, describe, Metadata */
+/* globals Metadata */
 
 'use strict';
 
diff --git a/test/unit/murmurhash3_spec.js b/test/unit/murmurhash3_spec.js
@@ -1,4 +1,4 @@
-/* globals jasmine, expect, it, describe, MurmurHash3_64 */
+/* globals MurmurHash3_64 */
 
 'use strict';
 
diff --git a/test/unit/network_spec.js b/test/unit/network_spec.js
@@ -1,4 +1,4 @@
-/* globals expect, it, describe, PDFNetworkStream */
+/* globals PDFNetworkStream */
 
 'use strict';
 
diff --git a/test/unit/parser_spec.js b/test/unit/parser_spec.js
@@ -1,4 +1,4 @@
-/* globals expect, it, describe, StringStream, Lexer, Name, Linearization */
+/* globals StringStream, Lexer, Name, Linearization */
 
 'use strict';
 
diff --git a/test/unit/stream_spec.js b/test/unit/stream_spec.js
@@ -1,5 +1,4 @@
-/* globals jasmine, expect, it, describe, beforeEach, Stream, PredictorStream,
-           Dict */
+/* globals Stream, PredictorStream, Dict */
 
 'use strict';
 
diff --git a/test/unit/type1_parser_spec.js b/test/unit/type1_parser_spec.js
@@ -1,5 +1,4 @@
-/* globals describe, it, expect, StringStream, Type1Parser,
-           SEAC_ANALYSIS_ENABLED */
+/* globals StringStream, Type1Parser, SEAC_ANALYSIS_ENABLED */
 
 'use strict';
 
diff --git a/test/unit/unicode_spec.js b/test/unit/unicode_spec.js
@@ -1,6 +1,6 @@
-/* globals describe, it, expect, beforeAll, afterAll, mapSpecialUnicodeValues,
-           getUnicodeForGlyph, getGlyphsUnicode, getDingbatsGlyphsUnicode,
-           getUnicodeRangeFor, getNormalizedUnicodes, reverseIfRtl */
+/* globals mapSpecialUnicodeValues, getUnicodeForGlyph, getGlyphsUnicode,
+           getDingbatsGlyphsUnicode, getUnicodeRangeFor, getNormalizedUnicodes,
+           reverseIfRtl */
 
 'use strict';
 
diff --git a/test/unit/util_spec.js b/test/unit/util_spec.js
@@ -1,4 +1,4 @@
-/* globals describe, it, expect, stringToPDFString, removeNullCharacters */
+/* globals stringToPDFString, removeNullCharacters */
 
 'use strict';
 
diff --git a/web/preferences.js b/web/preferences.js
@@ -12,7 +12,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-/* globals DEFAULT_PREFERENCES, chrome */
+/* globals DEFAULT_PREFERENCES */
 
 'use strict';
 
diff --git a/web/viewer.js b/web/viewer.js
@@ -12,7 +12,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-/*globals require, chrome */
+/* globals chrome */
 
 'use strict';
 

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-/* globals cp, ls, test */`
`2`		`-`
`3`	`1`	`'use strict';`
`4`	`2`
`5`	`3`	`var fs = require('fs'),`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-/* globals cat, cd, echo, ls */`
`2`	`1`	`'use strict';`
`3`	`2`
`4`	`3`	`require('shelljs/make');`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-/* globals cat, echo, exit, ls */`
`2`		`-`
`3`	`1`	`'use strict';`
`4`	`2`
`5`	`3`	`function checkIfCrlfIsPresent(files) {`