Skip to content

Commit 088e6ae

Browse files
bartvenemanBart Veneman
andauthored
close browser onerror (#40)
Co-authored-by: Bart Veneman <bart.veneman@drukwerkdeal.nl>
1 parent c59ed91 commit 088e6ae

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

api/_chromium.js

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ export const extractCss = async url => {
2525
// Make sure that we only try to extract CSS from valid pages.
2626
// Bail out if the response is an invalid request (400, 500)
2727
if (response.status() >= 400) {
28+
await browser.close()
2829
return Promise.reject(
2930
new Error(
3031
`There was an error retrieving CSS from ${url}.\n\tHTTP status code: ${response.statusCode} (${response.statusText})`
@@ -38,14 +39,13 @@ export const extractCss = async url => {
3839

3940
if (headers['content-type'].includes('text/css')) {
4041
const css = await response.text()
42+
await browser.close()
4143

42-
return Promise.resolve([
43-
{
44-
type: 'file',
45-
href: url,
46-
css
47-
}
48-
])
44+
return Promise.resolve([{
45+
type: 'file',
46+
href: url,
47+
css
48+
}])
4949
}
5050

5151
// Coverage contains a lot of <style> and <link> CSS,
@@ -105,9 +105,11 @@ export const extractCss = async url => {
105105
type: 'link-or-import'
106106
}))
107107

108-
const css = links
108+
const resources = links
109109
.concat(styleSheetsApiCss)
110110
.concat(inlineCss)
111111

112-
return Promise.resolve(css)
112+
await browser.close()
113+
114+
return Promise.resolve(resources)
113115
}

0 commit comments

Comments
 (0)