Remove copy method. It is not needed since every withXxx() method returns a copy

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1508966 13f79535-47bb-0310-9956-ffa450edef68

Author: britter

src/main/java/org/apache/commons/csv/CSVFormat.java

@@ -171,17 +171,6 @@ public static CSVFormat newFormat(final char delimiter) {
         return new CSVFormat(delimiter, null, null, null, null, false, false, null, null, null, false);
     }
 
-    /**
-     * Creates a CSVFormatBuilder, using the values of the given CSVFormat.
-     *
-     * @param format
-     *            The format to use values from
-     * @return a new CSVFormat
-     */
-    public static CSVFormat copy(final CSVFormat format) {
-        return new CSVFormat(format);
-    }
-
     /**
      * Creates a customized CSV format.
      *
@@ -230,12 +219,6 @@ public static CSVFormat copy(final CSVFormat format) {
         this.skipHeaderRecord = skipHeaderRecord;
     }
 
-    CSVFormat(final CSVFormat format) {
-        this(format.getDelimiter(), format.getQuoteChar(), format.getQuotePolicy(), format.getCommentStart(),
-                format.getEscape(), format.getIgnoreSurroundingSpaces(), format.getIgnoreEmptyLines(),
-                format.getRecordSeparator(), format.getNullString(), format.getHeader(), format.getSkipHeaderRecord());
-    }
-
     @Override
     public boolean equals(final Object obj) {
         if (this == obj) {

src/test/java/org/apache/commons/csv/CSVFormatTest.java

@@ -65,7 +65,7 @@ public void testDuplicateHeaderElements() {
     @Test
     public void testEquals() {
         final CSVFormat right = CSVFormat.DEFAULT;
-        final CSVFormat left = CSVFormat.copy(right);
+        final CSVFormat left = copy(right);
 
         assertFalse(right.equals(null));
         assertFalse(right.equals("A String Instance"));
@@ -84,7 +84,7 @@ public void testEqualsCommentStart() {
                 .withQuoteChar('"')
                 .withCommentStart('#')
                 .withQuotePolicy(Quote.ALL);
-        final CSVFormat left = CSVFormat.copy(right)
+        final CSVFormat left = right
                 .withCommentStart('!');
 
         assertNotEquals(right, left);
@@ -105,7 +105,7 @@ public void testEqualsEscape() {
                 .withCommentStart('#')
                 .withEscape('+')
                 .withQuotePolicy(Quote.ALL);
-        final CSVFormat left = CSVFormat.copy(right)
+        final CSVFormat left = right
                 .withEscape('!');
 
         assertNotEquals(right, left);
@@ -122,7 +122,7 @@ public void testEqualsHeader() {
                 .withIgnoreSurroundingSpaces(true)
                 .withQuoteChar('"')
                 .withQuotePolicy(Quote.ALL);
-        final CSVFormat left = CSVFormat.copy(right)
+        final CSVFormat left = right
                 .withHeader("Three", "Two", "One");
 
         assertNotEquals(right, left);
@@ -137,7 +137,7 @@ public void testEqualsIgnoreEmptyLines() {
                 .withIgnoreSurroundingSpaces(true)
                 .withQuoteChar('"')
                 .withQuotePolicy(Quote.ALL);
-        final CSVFormat left = CSVFormat.copy(right)
+        final CSVFormat left = right
                 .withIgnoreEmptyLines(false);
 
         assertNotEquals(right, left);
@@ -151,7 +151,7 @@ public void testEqualsIgnoreSurroundingSpaces() {
                 .withIgnoreSurroundingSpaces(true)
                 .withQuoteChar('"')
                 .withQuotePolicy(Quote.ALL);
-        final CSVFormat left = CSVFormat.copy(right)
+        final CSVFormat left = right
                 .withIgnoreSurroundingSpaces(false);
 
         assertNotEquals(right, left);
@@ -160,7 +160,7 @@ public void testEqualsIgnoreSurroundingSpaces() {
     @Test
     public void testEqualsQuoteChar() {
         final CSVFormat right = CSVFormat.newFormat('\'').withQuoteChar('"');
-        final CSVFormat left = CSVFormat.copy(right).withQuoteChar('!');
+        final CSVFormat left = right.withQuoteChar('!');
 
         assertNotEquals(right, left);
     }
@@ -170,7 +170,7 @@ public void testEqualsQuotePolicy() {
         final CSVFormat right = CSVFormat.newFormat('\'')
                 .withQuoteChar('"')
                 .withQuotePolicy(Quote.ALL);
-        final CSVFormat left = CSVFormat.copy(right)
+        final CSVFormat left = right
                 .withQuotePolicy(Quote.MINIMAL);
 
         assertNotEquals(right, left);
@@ -186,7 +186,7 @@ public void testEqualsRecordSeparator() {
                 .withIgnoreSurroundingSpaces(true)
                 .withQuoteChar('"')
                 .withQuotePolicy(Quote.ALL);
-        final CSVFormat left = CSVFormat.copy(right)
+        final CSVFormat left = right
                 .withRecordSeparator('!');
 
         assertNotEquals(right, left);
@@ -366,4 +366,8 @@ public void testWithRecordSeparator() throws Exception {
         CSVFormat formatWithRecordSeparator = CSVFormat.DEFAULT.withRecordSeparator('!');
         assertEquals("!", formatWithRecordSeparator.getRecordSeparator());
     }
+
+    private static CSVFormat copy(final CSVFormat format) {
+        return format.withDelimiter(format.getDelimiter());
+    }
 }