Hidden formelements don't hide

[ItsAsbreuk]

When form elements are hidden (by node-attribute hidden="hidden", then they ought to be invisible by the rule

pure [hidden] {
    display: none;
}

However, this is overruled by https://github.com/yui/pure/blob/master/src/forms/css/forms.css#L18

which makes the formelements visible again.

Regards,
Marco.

[tilomitra]

I don't think there's an explicit hidden class in Pure. If you're using any of these hidden classes, I usually use !important because you want the hidden to take precedence.

[ItsAsbreuk]

Hi Tilo,

I downloaded version 0.2.1 and here I found:

base.css - line 65:

[hidden] {
    display: none;
}

base-context.css - line 36:

.pure [hidden] {
    display: none;
}

But I can't find any base-files files here on github anymore. Are they removed?

Marco.

[ericf]

But I can't find any base-files files here on github anymore. Are they removed?

@ItsAsbreuk Yes they've been removed since Base is just Normalize. If you pull down Pure's source and build it they are added to the build/ dir, but not checked into source.

[ericf]

@ItsAsbreuk can you provide an example that shows this as broken?

[ItsAsbreuk]

Hi Eric,

1. hidden field without pure:
   http://jsbin.com/eKeMuWOm/1/edit?html,output
2. hidden -but still visible- with pure:
   http://jsbin.com/omikaD/1/edit?html,output
3. fixed solution for hidden fields with pure:
   http://jsbin.com/aDuzUyE/1/edit?html,output

Regards,
Marco

[ericf]

@ItsAsbreuk thanks! This is an interesting problem, for us to deal with the hidden HTML attribute we'd need to provide selectors with display: none; declaration after every place Pure adds a display declaration :-/

[ericf]

…and there's over 30.

[ItsAsbreuk]

Well, and you need to keep track of all future display-definitions...
Doesn't only one !important does the trick?

[hidden] {
    display: none !important;
  }

I guess you rather don't want to use !important, but perhaps for hidden there needs to be made an exception

[ericf]

!important is not appropriate for Pure to be using. We'll either figure out a solution for this to revive the usage of the hidden HTML attribute (ideal), or leave it up to developers to fix when they need to.

[ericf]

@ItsAsbreuk upon further thought and discussion with @tilomitra, it might be best to simply use what you're suggesting.

[ItsAsbreuk]

@ericf makes me glad to hear. Though I do understand the restraint for using !important.
Perhaps [hidden] should be a single exception, after all [hidden] means realy hidden under all circumstances.

[ericf]

!important is a sledge hammer that becomes a death spiral when you need to override it. Pure should be allergic to using it.

[ericf]

@ItsAsbreuk I have an update to this on a branch: https://github.com/ericf/pure/compare/hidden