Add [hidden] selector to Base to counteract all display declarations
#256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves Grids to be the second module (after Base) in the pure.css rollup files.
The grunt-contrib-csslint Grunt plugin does odd things with the way it processes CSSLint config. This improves linting by only applying in-file lint overrides on a per-module basis.
Anytime a Pure style rule uses the `display` declaration with a value
other than `none`, using the `hidden` HTML attribute on that element
won't have the desired affect of hiding that element. To counteract
this, A new rule has been added to Base to force
`display: none !important;` on elements that use the `hidden` HTML
attribute.
The following button will be hidden from view with these changes:
<button class="pure-button" hidden>No showy</button>
Fixes pure-css#177
tilomitra
added a commit
that referenced
this pull request
Dec 8, 2013
Add `[hidden]` selector to Base to counteract all `display` declarations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anytime a Pure style rule uses the
displaydeclaration with a value other thannone, using thehiddenHTML attribute on that element won't have the desired affect of hiding that element. To counteract this, A new rule has been added to Base to forcedisplay: none !important;on elements that use thehiddenHTML attribute.The following button will be hidden from view with these changes:
Fixes #177