Make private static classes final

garydgregory · garydgregory · commit 4deafd435aa0 · 2023-10-10T16:04:22.000-04:00
diff --git a/src/test/java/org/apache/commons/cli/OptionTest.java b/src/test/java/org/apache/commons/cli/OptionTest.java
@@ -29,7 +29,7 @@
 
 public class OptionTest {
 
-    private static class DefaultOption extends Option {
+    private static final class DefaultOption extends Option {
         private static final long serialVersionUID = 1L;
 
         private final String defaultValue;
@@ -45,7 +45,7 @@ public String getValue() {
         }
     }
 
-    private static class TestOption extends Option {
+    private static final class TestOption extends Option {
         private static final long serialVersionUID = 1L;
 
         TestOption(final String opt, final boolean hasArg, final String description) throws IllegalArgumentException {

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@`
`29`	`29`
`30`	`30`	`public class OptionTest {`
`31`	`31`
`32`		`- private static class DefaultOption extends Option {`
	`32`	`+ private static final class DefaultOption extends Option {`
`33`	`33`	`private static final long serialVersionUID = 1L;`
`34`	`34`
`35`	`35`	`private final String defaultValue;`
`@@ -45,7 +45,7 @@ public String getValue() {`
`45`	`45`	`}`
`46`	`46`	`}`
`47`	`47`
`48`		`- private static class TestOption extends Option {`
	`48`	`+ private static final class TestOption extends Option {`
`49`	`49`	`private static final long serialVersionUID = 1L;`
`50`	`50`
`51`	`51`	`TestOption(final String opt, final boolean hasArg, final String description) throws IllegalArgumentException {`