Skip to content

Sprockets still looking for sassc #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue Sep 9, 2021 · 4 comments
Closed

Sprockets still looking for sassc #10

ghost opened this issue Sep 9, 2021 · 4 comments

Comments

@ghost
Copy link

ghost commented Sep 9, 2021

Been trying out the new pipeline with sass as the --css option in Rails. It seems that Sprockets is still looking for sassc, which causes a Rails exception. Dart Sass is compiling fine to the build directory, so just looks like a legacy dependency issue.

I could get it working fine by uncommenting sassc-rails in the Gemfile, however this is obviously not needed with Dart Sass. I'm happy to open a PR on Rails main to remove the dependency if this is the agreed route.

@dhh
Copy link
Member

dhh commented Sep 9, 2021

I saw this and think I have a solution. We have to remove the link_tree stylesheets from the config/manifest.js. Will get this sorted.

@ghost
Copy link
Author

ghost commented Sep 9, 2021

Ah, of course — I forgot about the magic comments in Sprockets. Are they relevant anymore with the shiny new setup?

@ghost
Copy link
Author

ghost commented Sep 9, 2021

I can confirm that removing the link_tree line for the stylesheets in manifest.json fixes the issue. Would you like me to open a PR, or are you on it?

@dhh
Copy link
Member

dhh commented Sep 10, 2021

Fixed within #3 👍

@dhh dhh closed this as completed Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant