From 0d66086aab7d706974fdbe2c20d7001254d1fccb Mon Sep 17 00:00:00 2001
From: Andrew Roberts <andrew.roberts@parlai.com>
Date: Wed, 10 Sep 2014 13:21:26 -0400
Subject: [PATCH] use preventDefault instead of blindly returning false

---
 src/rails.js | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/src/rails.js b/src/rails.js
index ae4355c0..457b98e1 100644
--- a/src/rails.js
+++ b/src/rails.js
@@ -355,6 +355,8 @@
 
     $document.delegate(rails.linkClickSelector, 'click.rails', function(e) {
       var link = $(this), method = link.data('method'), data = link.data('params'), metaClick = e.metaKey || e.ctrlKey;
+      e.preventDefault();
+
       if (!rails.allowAction(link)) return rails.stopEverything(e);
 
       if (!metaClick && link.is(rails.linkDisableSelector)) rails.disableElement(link);
@@ -369,16 +371,17 @@
         } else {
           handleRemote.error( function() { rails.enableElement(link); } );
         }
-        return false;
+        // return false;
 
       } else if (link.data('method')) {
         rails.handleMethod(link);
-        return false;
+        // return false;
       }
     });
 
     $document.delegate(rails.buttonClickSelector, 'click.rails', function(e) {
       var button = $(this);
+      e.preventDefault();
 
       if (!rails.allowAction(button)) return rails.stopEverything(e);
 
@@ -391,15 +394,17 @@
       } else {
         handleRemote.error( function() { rails.enableFormElement(button); } );
       }
-      return false;
+      // return false;
     });
 
     $document.delegate(rails.inputChangeSelector, 'change.rails', function(e) {
       var link = $(this);
       if (!rails.allowAction(link)) return rails.stopEverything(e);
 
+      e.preventDefault();
       rails.handleRemote(link);
-      return false;
+
+      // return false;
     });
 
     $document.delegate(rails.formSubmitSelector, 'submit.rails', function(e) {
@@ -433,7 +438,8 @@
         }
 
         rails.handleRemote(form);
-        return false;
+        e.preventDefault();
+        // return false;
 
       } else {
         // slight timeout so that the submit button gets properly serialized