Fix insertBefore: use splice instead.

>insertBefore will misreplace `*display:none` with `display:none`

Author: zoubin

index.js

@@ -196,8 +196,12 @@ function insertBefore(rule, child) {
   }
   childNodes.forEach(function (node) {
     node.parent = rule.parent
-    rule.parent.insertBefore(rule, node)
+    // DO NOT use insertBefore
+    // declarations like `*display:none` will be transformed to `display:none`
+    //rule.parent.insertBefore(rule, node)
   })
+  var nodes = rule.parent.nodes
+  nodes.splice.apply(nodes, [ nodes.indexOf(rule), 0 ].concat(childNodes))
 }
 
 function createEmitter() {

test/emitter.js

@@ -49,7 +49,7 @@ test('emitter', function(t) {
     postcssOpts
   )
   .then(function (result) {
-    t.equal(result.css, 'a {}\nb {}\nc {}\nf {}\ne {}\nd {}')
+    t.equal(result.css, 'a {}b {}c {}\nf {}\ne {}\nd {}')
   })
   .catch(function (err) {
     t.error(err)

test/glob.js

@@ -5,6 +5,6 @@ test('glob', run.bind(
   null,
   { glob: true },
   { file: 'glob_imports/glob.css', source: '@import "*.css";' },
-  { source: 'a {}\nb {}\nc {}' }
+  { source: 'a {}b {}c {}' }
 ))
 

test/insertBefore.js

@@ -0,0 +1,40 @@
+var test = require('tape')
+var atImport = require('..')
+var postcss = require('postcss')
+var path = require('path')
+var fixtures = require('./util/fixtures')
+
+var contents = {
+  d: '@import "e.css";\nie7 { *display: inline; }',
+  e: '@import "f.css";\nie8 { display: inline\\0; }',
+  f: '@import "g.css";\nie89 { display: inline\\0/IE8+9; }',
+  g: 'ie9 { display: inline\\0/IE9; }',
+}
+
+var entry = fixtures('emitter.css')
+
+test('insertBefore', function(t) {
+  var postcssOpts = { from: entry }
+  return postcss(atImport({
+    importer: function (url) {
+      var base = path.basename(url, '.css')
+      return Promise.resolve({
+        from: fixtures(url),
+        source: contents[base],
+      })
+    },
+  }))
+  .process(
+    '@import "d.css";\nie6{ _display: inline; }',
+    postcssOpts
+  )
+  .then(function (result) {
+    var fs = require('fs')
+    fs.writeFileSync('x.css', result.css)
+    t.equal(result.css, 'ie9 { display: inline\\0/IE9; }\nie89 { display: inline\\0/IE8+9; }\nie8 { display: inline\\0; }\nie7 { *display: inline; }\nie6{ _display: inline; }')
+  })
+  .catch(function (err) {
+    t.error(err)
+  })
+})
+