Skip to content

Sourcemap support #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ilyvion opened this issue May 3, 2018 · 4 comments
Closed

Sourcemap support #4

ilyvion opened this issue May 3, 2018 · 4 comments

Comments

@ilyvion
Copy link

ilyvion commented May 3, 2018

As soon as I added the group-css-media-queries-loader to my chain, sourcemap support broke down. I tried adding options: {sourceMap: true} to the loader, like you can do on the sass-loader and the css-loader, but it made no difference.

What has to be done in order for sourcemaps to still work when using this loader?

@retyui
Copy link
Owner

retyui commented May 3, 2018

@alexschrod Hi!
The group-css-media-queries the module did not support configuration.
I created a temporary wrapper https://github.com/retyui/group-css-media-queries-loader/tree/next, Where did I add support sourceMap

Install

yarn add -D group-css-media-queries-loader@next
# or npm i -D group-css-media-queries-loader@next

@ilyvion
Copy link
Author

ilyvion commented May 5, 2018

Hey, thanks a lot! I was so busy the last couple of days at work that I didn't have time to try it out, but I definitely will as soon as I can.

@retyui retyui closed this as completed May 6, 2018
@ilyvion
Copy link
Author

ilyvion commented May 10, 2018

Hey, I tested it, and it mostly works, although it seems to get confused when there are two files that share the same name, although that's certainly not the end of the world and it's still much better than it was before.

@retyui
Copy link
Owner

retyui commented May 10, 2018

@alexschrod

two files that share the same name

Can you create a test repository with a this problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants