Skip to content

Commit 257221f

Browse files
Temporarily comment out binding nullification in MediaDetailPagerFragment.onDestroyView() (commons-app#6589)
* Initial plan * Temporarily comment out binding = null in MediaDetailPagerFragment.onDestroyView() Co-authored-by: RitikaPahwa4444 <83745993+RitikaPahwa4444@users.noreply.github.com> * Add link to this decision as a comment * Bump up version code and name for the patch release Update CHANGELOG.md --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: RitikaPahwa4444 <83745993+RitikaPahwa4444@users.noreply.github.com> Co-authored-by: Ritika Pahwa <ritikapahwa4444@gmail.com>
1 parent 1541f78 commit 257221f

File tree

3 files changed

+11
-3
lines changed

3 files changed

+11
-3
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# Wikimedia Commons for Android
22

3+
## v6.2.1
4+
5+
### What's changed
6+
* The app no longer crashes on navigating from the MainActivity to other activities
7+
* Support for larger zoom levels on the image upload preview screen
8+
39
## v6.2.0
410

511
### What's changed

app/build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ android {
2424
applicationId = "fr.free.nrw.commons"
2525
minSdk = 21
2626
targetSdk = 35
27-
versionCode = 1060
28-
versionName = "6.2.0"
27+
versionCode = 1061
28+
versionName = "6.2.1"
2929

3030
setProperty("archivesBaseName", "app-commons-v$versionName-" + getBranchName())
3131
testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"

app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,9 @@ class MediaDetailPagerFragment : CommonsDaggerSupportFragment(), OnPageChangeLis
145145
if (activity is MainActivity) {
146146
(activity as MainActivity).showTabs()
147147
}
148-
binding = null
148+
149+
// Temporarily disable it. Ref:https://github.com/commons-app/apps-android-commons/issues/6581#issuecomment-3694210567
150+
// binding = null
149151
}
150152

151153
/**

0 commit comments

Comments
 (0)