Fixed flickering of nearby banner compass (commons-app#5486)

Author: ShashwatKedia

app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragment.java

@@ -542,7 +542,7 @@ private void updateNearbyNotification(@Nullable NearbyController.NearbyPlacesInf
             String distance = formatDistanceBetween(curLatLng, closestNearbyPlace.location);
             closestNearbyPlace.setDistance(distance);
             direction = (float) computeBearing(curLatLng, closestNearbyPlace.location);
-            nearbyNotificationCardView.updateContent(closestNearbyPlace, direction);
+            nearbyNotificationCardView.updateContent(closestNearbyPlace);
         } else {
             // Means that no close nearby place is found
             nearbyNotificationCardView.setVisibility(View.GONE);

app/src/main/java/fr/free/nrw/commons/nearby/NearbyNotificationCardView.java

@@ -113,11 +113,11 @@ private void succeeded() {
     }
 
     /**
-     * Pass place information to views and set compass arrow direction
+     * Pass place information to views
+     *
      * @param place Closes place where we will get information from
-     * @param direction Direction in which compass arrow needs to be set
      */
-    public void updateContent(Place place, float direction) {
+    public void updateContent(Place place) {
         Timber.d("Update nearby card notification content");
         this.setVisibility(VISIBLE);
         cardViewVisibilityState = CardViewVisibilityState.READY;
@@ -132,7 +132,6 @@ public void updateContent(Place place, float direction) {
         notificationIcon.setVisibility(VISIBLE);
         notificationTitle.setText(place.name);
         notificationDistance.setText(place.distance);
-        notificationCompass.setRotation(direction);
     }
 
     @Override