Skip to content

Commit 8255bac

Browse files
committed
Don't store Activity instance in adapter.
1 parent 40c1ea3 commit 8255bac

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

app/src/main/java/fr/free/nrw/commons/contributions/ContributionsActivity.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ public Loader<Cursor> onCreateLoader(int i, Bundle bundle) {
227227
@Override
228228
public void onLoadFinished(Loader<Cursor> cursorLoader, Cursor cursor) {
229229
if(contributionsList.getAdapter() == null) {
230-
contributionsList.setAdapter(new ContributionsListAdapter(this, cursor, 0));
230+
contributionsList.setAdapter(new ContributionsListAdapter(getApplicationContext(), cursor, 0));
231231
} else {
232232
((CursorAdapter)contributionsList.getAdapter()).swapCursor(cursor);
233233
}

app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListAdapter.java

+4-6
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,23 @@
11
package fr.free.nrw.commons.contributions;
22

3-
import android.app.Activity;
43
import android.content.Context;
54
import android.database.Cursor;
65
import android.support.v4.widget.CursorAdapter;
6+
import android.view.LayoutInflater;
77
import android.view.View;
88
import android.view.ViewGroup;
99

1010
import fr.free.nrw.commons.R;
1111

1212
class ContributionsListAdapter extends CursorAdapter {
13-
private Activity activity;
1413

15-
public ContributionsListAdapter(Activity activity, Cursor c, int flags) {
16-
super(activity, c, flags);
17-
this.activity = activity;
14+
public ContributionsListAdapter(Context context, Cursor c, int flags) {
15+
super(context, c, flags);
1816
}
1917

2018
@Override
2119
public View newView(Context context, Cursor cursor, ViewGroup viewGroup) {
22-
View parent = activity.getLayoutInflater().inflate(R.layout.layout_contribution, viewGroup, false);
20+
View parent = LayoutInflater.from(context).inflate(R.layout.layout_contribution, viewGroup, false);
2321
parent.setTag(new ContributionViewHolder(parent));
2422
return parent;
2523
}

0 commit comments

Comments
 (0)