Fixing Findbugs warnings and adding a bold WARNING to GnuParser that there is a large lump of non-executable code

git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/cli/branches/cli-1.0.x@542151 13f79535-47bb-0310-9956-ffa450edef68

Author: hen

src/java/org/apache/commons/cli/GnuParser.java

@@ -106,6 +106,10 @@ else if (stopAtNonOption)
                 }
                 else
                 {
+                    // WARNING: Findbugs reports major problems with the following code. 
+                    //          As option cannot be null, currentOption cannot and 
+                    //          much of the code below is never going to be run.
+
                     currentOption = option;
 
                     // special option
@@ -169,6 +173,6 @@ else if (stopAtNonOption)
             }
         }
 
-        return (String[]) tokens.toArray(new String[] {  });
+        return (String[]) tokens.toArray(new String[tokens.size()]);
     }
-}
+}

src/java/org/apache/commons/cli/Option.java

@@ -541,7 +541,7 @@ public String getValue(String defaultValue)
     public String[] getValues()
     {
         return hasNoValues()
-               ? null : (String[]) this.values.toArray(new String[] {  });
+               ? null : (String[]) this.values.toArray(new String[this.values.size()]);
     }
 
     /**

src/java/org/apache/commons/cli/PosixParser.java

@@ -160,7 +160,7 @@ else if (options.hasOption(token)) {
             gobble(iter);
         }
 
-        return (String[]) tokens.toArray(new String[] {  });
+        return (String[]) tokens.toArray(new String[tokens.size()]);
     }
 
     /**
@@ -308,4 +308,4 @@ else if (stopAtNonOption)
             }
         }
     }
-}
+}

src/java/org/apache/commons/cli/TypeHandler.java

@@ -208,14 +208,7 @@ public static Class createClass(String str)
      */
     public static Date createDate(String str)
     {
-        Date date = null;
-
-        if (date == null)
-        {
-            System.err.println("Unable to parse: " + str);
-        }
-
-        return date;
+        throw new UnsupportedOperationException("Not yet implemented");
     }
 
     /**