create the parser using a classname parameter instead of a system property

git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/cli/trunk@129789 13f79535-47bb-0310-9956-ffa450edef68

Author: John Keyes

src/java/org/apache/commons/cli/CommandLineParserFactory.java

@@ -1,7 +1,7 @@
 /*
- * $Header: /home/jerenkrantz/tmp/commons/commons-convert/cvs/home/cvs/jakarta-commons//cli/src/java/org/apache/commons/cli/Attic/CommandLineParserFactory.java,v 1.1 2002/07/04 22:32:12 jkeyes Exp $
- * $Revision: 1.1 $
- * $Date: 2002/07/04 22:32:12 $
+ * $Header: /home/jerenkrantz/tmp/commons/commons-convert/cvs/home/cvs/jakarta-commons//cli/src/java/org/apache/commons/cli/Attic/CommandLineParserFactory.java,v 1.2 2002/07/25 21:40:08 jkeyes Exp $
+ * $Revision: 1.2 $
+ * $Date: 2002/07/25 21:40:08 $
  *
  * ====================================================================
  *
@@ -76,9 +76,12 @@ public class CommandLineParserFactory {
      * @return the CommandLineParser
      */
     public static CommandLineParser newParser() {
-        String parserImpl = System.getProperty( "org.apache.commons.cli.parser" );
+        return newParser( DEFAULT_PARSER );
+    }
+
+    public static CommandLineParser newParser( String classname ) {
         try {
-            return (CommandLineParser)Class.forName( parserImpl ).newInstance();
+            return (CommandLineParser)Class.forName( classname ).newInstance();
         }
         catch( Exception exp ) {
             // could not create according to parserImpl so default to

src/test/org/apache/commons/cli/ApplicationTest.java

@@ -35,10 +35,7 @@ public ApplicationTest(String name)
      */
     public void testAnt() {
         // use the GNU parser
-        System.setProperty( "org.apache.commons.cli.parser",
-                            "org.apache.commons.cli.GnuParser");
-
-        CommandLineParser parser = CommandLineParserFactory.newParser();
+        CommandLineParser parser = CommandLineParserFactory.newParser( "org.apache.commons.cli.GnuParser" );
         Options options = new Options();
         options.addOption( "help", false, "print this message" );
         options.addOption( "projecthelp", false, "print project help information" );

src/test/org/apache/commons/cli/GnuParseTest.java

@@ -5,7 +5,7 @@
  * version 1.1, a copy of which has been included with this distribution in
  * the LICENSE file.
  * 
- * $Id: GnuParseTest.java,v 1.1 2002/07/04 22:32:12 jkeyes Exp $
+ * $Id: GnuParseTest.java,v 1.2 2002/07/25 21:40:08 jkeyes Exp $
  */
 
 package org.apache.commons.cli;
@@ -30,9 +30,6 @@ public GnuParseTest( String name )
 
     public void setUp()
     {
-        System.setProperty( "org.apache.commons.cli.parser",
-                            "org.apache.commons.cli.GnuParser");
-
         _options = new Options()
             .addOption("a",
                        "enable-a",
@@ -47,7 +44,7 @@ public void setUp()
                        false,
                        "turn [c] on or off");
 
-        _parser = CommandLineParserFactory.newParser();
+        _parser = CommandLineParserFactory.newParser( "org.apache.commons.cli.GnuParser" );
     }
 
     public void tearDown()