-
Notifications
You must be signed in to change notification settings - Fork 350
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: rstaib/jquery-bootgrid
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: rstaib/jquery-bootgrid
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: template-cache
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 13 commits
- 5 files changed
- 1 contributor
Commits on Oct 12, 2015
-
there is no need to clone() here, it creates a memory leak as it's not attached the to DOM and therefore isn't removed by remove()
Configuration menu - View commit details
-
Copy full SHA for fe3f95e - Browse repository at this point
Copy the full SHA fe3f95eView commit details
Commits on Oct 30, 2015
-
Trigger an event when columns are toggled on or off
Configuration menu - View commit details
-
Copy full SHA for 1225b4a - Browse repository at this point
Copy the full SHA 1225b4aView commit details
Commits on Sep 15, 2016
-
Drastically faster templating approach
The current templating approach is really inefficient, as it recursively loops thru every passed available variable for substituion and applies a regex for each one. It's much faster to initially parse the template and then only process those strings which are actually present in the template. This revised implementation both caches the parsed templates and then only processes the string which are present. The performance improvement is quite drastic, especially with large tables. A large table was previously taking 15s to render in Chrome, now takes less than 1s with this approach
Configuration menu - View commit details
-
Copy full SHA for 2d26fea - Browse repository at this point
Copy the full SHA 2d26feaView commit details -
Configuration menu - View commit details
-
Copy full SHA for d33185d - Browse repository at this point
Copy the full SHA d33185dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d11d27 - Browse repository at this point
Copy the full SHA 8d11d27View commit details
Commits on Dec 9, 2016
-
move label infos templated string into templates
rather than needing to recursively process every string, move the templated string for infos into the template definitions
Configuration menu - View commit details
-
Copy full SHA for f7cfe39 - Browse repository at this point
Copy the full SHA f7cfe39View commit details
Commits on Dec 10, 2016
-
added more append options + timing
added buttons to append 10, 100 and 1000 rows with logging of rendering time (on screen and to console)
Configuration menu - View commit details
-
Copy full SHA for 0c66fe2 - Browse repository at this point
Copy the full SHA 0c66fe2View commit details -
don't set the replacement value to null when a property doesn't exist
Configuration menu - View commit details
-
Copy full SHA for e96981a - Browse repository at this point
Copy the full SHA e96981aView commit details -
added back in the old method and evaluate the template string using both approaches, log out to console any different results found
Configuration menu - View commit details
-
Copy full SHA for 52e55ad - Browse repository at this point
Copy the full SHA 52e55adView commit details -
refactored functions out from string and array protoypes included appendRow changes from #285 (50% faster in Chrome, 10% Edge, 15% FF)
Configuration menu - View commit details
-
Copy full SHA for cef18bc - Browse repository at this point
Copy the full SHA cef18bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 10197d2 - Browse repository at this point
Copy the full SHA 10197d2View commit details -
remove prototypes from string and array merge in appendRow #285 improves Chrome 50%, FF 15%, Edge 10%
Configuration menu - View commit details
-
Copy full SHA for 94e1e5b - Browse repository at this point
Copy the full SHA 94e1e5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f9ee37f - Browse repository at this point
Copy the full SHA f9ee37fView commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...template-cache