Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rstaib/jquery-bootgrid
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: rstaib/jquery-bootgrid
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: template-cache
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 13 commits
  • 5 files changed
  • 1 contributor

Commits on Oct 12, 2015

  1. Update internal.js

    there is no need to clone() here,  it creates a memory leak as it's not attached the to DOM and therefore isn't removed by remove()
    zspitzer committed Oct 12, 2015
    Configuration menu
    Copy the full SHA
    fe3f95e View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2015

  1. Add an event columnToggle

    Trigger an event when columns are toggled on or off
    zspitzer committed Oct 30, 2015
    Configuration menu
    Copy the full SHA
    1225b4a View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2016

  1. Drastically faster templating approach

    The current templating approach is really inefficient, as it recursively loops thru every 
    passed available variable for substituion and applies a regex for each one. 
    
    It's much faster to initially parse the template and then only process those strings which are 
    actually present in the template.
    
    This revised implementation both caches the parsed templates and then only processes the string which are present.
    
    The performance improvement is quite drastic, especially with large tables. A large table was previously taking 15s to render 
    in Chrome, now takes less than 1s with this approach
    zspitzer authored Sep 15, 2016
    Configuration menu
    Copy the full SHA
    2d26fea View commit details
    Browse the repository at this point in the history
  2. Update extensions.js

    zspitzer authored Sep 15, 2016
    Configuration menu
    Copy the full SHA
    d33185d View commit details
    Browse the repository at this point in the history
  3. lint clean up

    zspitzer authored Sep 15, 2016
    Configuration menu
    Copy the full SHA
    8d11d27 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2016

  1. move label infos templated string into templates

    rather than needing to recursively process every string, move the templated string for infos into the template definitions
    zspitzer authored Dec 9, 2016
    Configuration menu
    Copy the full SHA
    f7cfe39 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2016

  1. added more append options + timing

    added buttons to append 10, 100 and 1000 rows with logging of rendering time (on screen and to console)
    zspitzer authored Dec 10, 2016
    Configuration menu
    Copy the full SHA
    0c66fe2 View commit details
    Browse the repository at this point in the history
  2. avoid null result

    don't set the replacement value to null when a property doesn't exist
    zspitzer authored Dec 10, 2016
    Configuration menu
    Copy the full SHA
    e96981a View commit details
    Browse the repository at this point in the history
  3. test to compare final results

    added back in the old method and evaluate the template string using both approaches,
    log out to console any different results found
    zspitzer authored Dec 10, 2016
    Configuration menu
    Copy the full SHA
    52e55ad View commit details
    Browse the repository at this point in the history
  4. refactor out prototypes

    refactored functions out from string and array protoypes
    included appendRow changes from #285 (50% faster in Chrome, 10% Edge,
    15% FF)
    zspitzer committed Dec 10, 2016
    Configuration menu
    Copy the full SHA
    cef18bc View commit details
    Browse the repository at this point in the history
  5. Revert "refactor out prototypes"

    This reverts commit cef18bc.
    zspitzer committed Dec 10, 2016
    Configuration menu
    Copy the full SHA
    10197d2 View commit details
    Browse the repository at this point in the history
  6. refactor out base prototypes

    remove prototypes from string and array
    merge in appendRow #285  improves Chrome 50%, FF 15%, Edge 10%
    zspitzer committed Dec 10, 2016
    Configuration menu
    Copy the full SHA
    94e1e5b View commit details
    Browse the repository at this point in the history
  7. remove appendRow

    no longer needed since appendRows
    zspitzer committed Dec 10, 2016
    Configuration menu
    Copy the full SHA
    f9ee37f View commit details
    Browse the repository at this point in the history
Loading