Skip to content

Webpack 5 support? #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
osmestad opened this issue Nov 11, 2020 · 4 comments
Closed

Webpack 5 support? #28

osmestad opened this issue Nov 11, 2020 · 4 comments
Assignees

Comments

@osmestad
Copy link

Hi, I'm trying to update a project to Webpack 5, but I'm getting an error I suspect is from this plugin:

Building(node:30678) [DEP_WEBPACK_COMPILATION_ASSETS] DeprecationWarning: Compilation.assets will be frozen in future, all modifications are deprecated.
BREAKING CHANGE: No more changes should happen to Compilation.assets after sealing the Compilation.
	Do changes to assets earlier, e. g. in Compilation.hooks.processAssets.
	Make sure to select an appropriate stage from Compilation.PROCESS_ASSETS_STAGE_*.
    at /Users/osmestad/Code/webclient-app/node_modules/html-inline-css-webpack-plugin/build/core/base-plugin.js:34:39
    at Array.forEach (<anonymous>)
    at PluginForHtmlWebpackPluginV4.BasePlugin.prepare (/Users/osmestad/Code/webclient-app/node_modules/html-inline-css-webpack-plugin/build/core/base-plugin.js:30:33)
    at /Users/osmestad/Code/webclient-app/node_modules/html-inline-css-webpack-plugin/build/core/v4.js:69:27
    at eval (eval at create (/Users/osmestad/Code/webclient-app/node_modules/tapable/lib/HookCodeFactory.js:74:10), <anonymous>:17:16)
    at new Promise (<anonymous>)
    at AsyncSeriesWaterfallHook.eval [as promise] (eval at create (/Users/osmestad/Code/webclient-app/node_modules/tapable/lib/HookCodeFactory.js:74:10), <anonymous>:4:8)
    at AsyncSeriesWaterfallHook.lazyCompileHook (/Users/osmestad/Code/webclient-app/node_modules/tapable/lib/Hook.js:154:20)
    at /Users/osmestad/Code/webclient-app/node_modules/html-webpack-plugin/index.js:187:84
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)

Versions used:
"webpack": "5.4.0"
"html-webpack-plugin": "4.5.0",
"mini-css-extract-plugin": "1.3.0",
"html-inline-css-webpack-plugin": "1.9.0",

Is Webpack 5 support planned?

@osmestad
Copy link
Author

Update: I guess it is a warning not error (yet) as the build seems to pass when I cleared up some other errors :-)

@runjuu runjuu self-assigned this Nov 12, 2020
@runjuu
Copy link
Owner

runjuu commented Nov 12, 2020

Hi @osmestad , I will take a look in a few days. 😉

@runjuu
Copy link
Owner

runjuu commented Nov 16, 2020

@osmestad It seems like the warning is caused by html-webpack-plugin (issue). I've tried the alpha version of html-webpack-plugin and the warning is gone 😜.

@osmestad
Copy link
Author

Aha, thank you for looking into it!
I'll close this and assume the warning disappears when that package gets updated then :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants