Skip to content

Commit d2b1604

Browse files
committed
Make jshint stricter and cleanup lint warnings
1 parent 34cd172 commit d2b1604

File tree

2 files changed

+10
-11
lines changed

2 files changed

+10
-11
lines changed

Gruntfile.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,9 @@ module.exports = function(grunt) {
8282
all: ['Gruntfile.js', 'src/**/*.js'],
8383
options: {
8484
curly: true,
85-
// eqeqeq: true,
86-
// immed: true,
85+
eqeqeq: true,
86+
unused: true,
87+
immed: true,
8788
latedef: true,
8889
newcap: true,
8990
noarg: true,

src/jquery.smooth-scroll.js

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,11 @@ var version = '1.4.13',
3636
getScrollable = function(opts) {
3737
var scrollable = [],
3838
scrolled = false,
39-
dir = opts.dir && opts.dir == 'left' ? 'scrollLeft' : 'scrollTop';
39+
dir = opts.dir && opts.dir === 'left' ? 'scrollLeft' : 'scrollTop';
4040

4141
this.each(function() {
4242

43-
if (this == document || this == window) { return; }
43+
if (this === document || this === window) { return; }
4444
var el = $(this);
4545
if ( el[dir]() > 0 ) {
4646
scrollable.push(this);
@@ -61,7 +61,7 @@ var version = '1.4.13',
6161
// (doing this because Safari sets scrollTop async,
6262
// so can't set it to 1 and immediately get the value.)
6363
if (!scrollable.length) {
64-
this.each(function(index) {
64+
this.each(function() {
6565
if (this.nodeName === 'BODY') {
6666
scrollable = [this];
6767
}
@@ -74,8 +74,7 @@ var version = '1.4.13',
7474
}
7575

7676
return scrollable;
77-
},
78-
isTouch = 'ontouchend' in document;
77+
};
7978

8079
$.fn.extend({
8180
scrollable: function(dir) {
@@ -163,8 +162,7 @@ $.smoothScroll = function(options, px) {
163162
offPos = 'offset',
164163
scrollDir = 'scrollTop',
165164
aniProps = {},
166-
aniOpts = {},
167-
scrollprops = [];
165+
aniOpts = {};
168166

169167
if (typeof options === 'number') {
170168
opts = $.extend({link: null}, $.fn.smoothScroll.defaults, optionOverrides);
@@ -173,13 +171,13 @@ $.smoothScroll = function(options, px) {
173171
opts = $.extend({link: null}, $.fn.smoothScroll.defaults, options || {}, optionOverrides);
174172
if (opts.scrollElement) {
175173
offPos = 'position';
176-
if (opts.scrollElement.css('position') == 'static') {
174+
if (opts.scrollElement.css('position') === 'static') {
177175
opts.scrollElement.css('position', 'relative');
178176
}
179177
}
180178
}
181179

182-
scrollDir = opts.direction == 'left' ? 'scrollLeft' : scrollDir;
180+
scrollDir = opts.direction === 'left' ? 'scrollLeft' : scrollDir;
183181

184182
if ( opts.scrollElement ) {
185183
$scroller = opts.scrollElement;

0 commit comments

Comments
 (0)