Skip to content

Commit 87886fe

Browse files
feat(src/index.js): Check NODE_ENV
Only attempt to inject HOT if in development, as a safety to production builds
1 parent 1aba64d commit 87886fe

File tree

1 file changed

+26
-24
lines changed

1 file changed

+26
-24
lines changed

src/index.js

+26-24
Original file line numberDiff line numberDiff line change
@@ -146,31 +146,33 @@ class ExtractCssChunks {
146146
}
147147

148148
apply(compiler) {
149-
try {
150-
const isHOT = isHMR(compiler);
151-
152-
if (isHOT && compiler.options.module && compiler.options.module.rules) {
153-
const updatedRules = compiler.options.module.rules.reduce((rules, rule) => {
154-
if (rule.use && Array.isArray(rule.use)) {
155-
const isMiniCss = rule.use.some((l) => {
156-
const needle = l.loader || l;
157-
return needle.includes(pluginName);
158-
});
159-
if (isMiniCss) {
160-
rule.use.unshift(hotLoader);
161-
}
162-
}
163-
rules.push(rule);
164-
165-
return rules;
166-
}, []);
167-
168-
compiler.options.module.rules = updatedRules;
169-
}
170-
} catch (e) {
171-
console.error('Something went wrong: contact the author', e);
172-
}
173149

150+
if(process.env.NODE_ENV === 'development') {
151+
try {
152+
const isHOT = isHMR(compiler);
153+
154+
if (isHOT && compiler.options.module && compiler.options.module.rules) {
155+
const updatedRules = compiler.options.module.rules.reduce((rules, rule) => {
156+
if (rule.use && Array.isArray(rule.use)) {
157+
const isMiniCss = rule.use.some((l) => {
158+
const needle = l.loader || l;
159+
return needle.includes(pluginName);
160+
});
161+
if (isMiniCss) {
162+
rule.use.unshift(hotLoader);
163+
}
164+
}
165+
rules.push(rule);
166+
167+
return rules;
168+
}, []);
169+
170+
compiler.options.module.rules = updatedRules;
171+
}
172+
} catch (e) {
173+
console.error('Something went wrong: contact the author', e);
174+
}
175+
}
174176

175177
compiler.hooks.thisCompilation.tap(pluginName, (compilation) => {
176178
compilation.hooks.normalModuleLoader.tap(pluginName, (lc, m) => {

0 commit comments

Comments
 (0)